This repository was archived by the owner on Oct 13, 2020. It is now read-only.
This repository was archived by the owner on Oct 13, 2020. It is now read-only.
wg-runtime Status Update 2020-08-17 #41
Description
What was accomplished
Justin
- CL reviews for amp-img ssr work, finding bugs in other go transformers
- Helped with debugging cherry-pick issues
- Cleaned up 2 ancient experiments (fixit!)
- Worked on auto-envelope, but unhappy with it
- Bundling 2 element implementations seems wasteful for amp-mode, and bundling specific code in bento-mode
- Created experimental cache transform for amp-bind
Jake
- 🎉 Launched protocol adapters (amp-list: launch protocol adapters in canary and prod amphtml#29689)
- 📈 Made headway on bento css integration (bento: add jss styling for amp-carousel. amphtml#29713, bento: customize jss insertion point to support shadow amphtml#29794)
- 🔎 Made a prototype amp-optimizer docker image
- 🛠️ Fixes:
- inputmask incorrect usage static this: of 🐛 inputmask: remove static from fn using
thisamphtml#29646 - inputmask attempting to mask svgs: 🐛 amp-inputmask: query is too zealous amphtml#29624
- improve hash error: <amp-script>: Fix and improve error messages for script hash amphtml#29614
- inputmask incorrect usage static this: of 🐛 inputmask: remove static from fn using
Will
- Rolled out “intersect-resources” to 100% prod
- Fixed a couple email-related bugs in amp-list (amp-list: Fix layoutCallback promise chain in SSR path amphtml#29726)
- Fix-it bugs related to AMP.navigateTo
Lessons learned
- In our error logs, we get a referrer url which can significantly help reproducing issues
What's next
Justin
- Finish CL of amp-img ssr and related transformers
- Finish auto-envelope for Bento
- Update amp-bind code to support SSR transform
Jake
- Continue work on bento css + amp-optimizer docker image
- 🤞 Launch StrictCompilation
- fixits:
- validator extension bug: Elaborate error message for amp-script with attribute data-ampdevmode amphtml#29457
Will
- Transition plan
- Fix-it: clean up old TODOs