This repository was archived by the owner on Nov 16, 2021. It is now read-only.
This repository was archived by the owner on Nov 16, 2021. It is now read-only.
wg-bento Status Update 2021-03-01 #55
Description
What was accomplished ✅
Fix it week 🔨
amp-youtubesupportscurrentTimeanddurationin imperative API ✨ Youtube 1.0: get duration, currentTime amphtml#32804amp-selectorhas stylistic support for hybriddisabled+selectedstate Bento Selector: Support hybrid selected/disabled state amphtml#32825amp-accordion0.1and1.0respect pre-existingroleattributes ✨ [bento][amp-accordion][fixit] Check for pre-existing role attribute before using default value amphtml#32915amp-timeago0.1and1.0migrated to latesttimeago.jslibrary (fromthird_party/tonode_modules) and now have support for 7 more languages- e2e tests for
amp-sidebar✅ [bento][amp-sidebar][fixit] Port sidebar e2e tests to from 0.1 to 1.0 amphtml#32837,amp-social-share✅ [bento][amp-social-share][fixit] Add e2e tests for social-share amphtml#32881, andamp-accordion✅ [bento][amp-accordion][fixit] Bento accordion e2e tests amphtml#32958 - Documented media-based attributes and enabled on
amp-fit-textEnable media attributes for amp-fit-text:1.0 amphtml#32824 BaseElement['props']refactor to simplify children configurations ♻️ Bento: BaseElement['props'] to include children, passthrough, passthroughNonEmpty amphtml#32936objstr:- used in more components ♻️ Use objstr in Bento components amphtml#32893
- compiles down 🏗 Use babel-plugin-optimize-objstr amphtml#32872
- JSS:
- transform compiled output to
export const classNamefor filesize 🏗 Transform imported JSS properties into their resolved classnames amphtml#32888 - collect z-index 🏗 Collect z-index from JS files amphtml#32847
- transform compiled output to
- Shadow DOM polyfill Shadow DOM polyfill for elements that need it amphtml#32820
General 🍱
LightboxGalleryPreact implementation- component file restructuring for npm packaging
- NPM binary generation with ES build
- design review for deferred build and async pause systems
- Use
gulp get-zindex [--fix]to make surecss/Z_INDEX.mdis up to date
Lessons learned 👩🎓
- We can stop prettier from exploding the boilerplate code on HTML documents by disabling prettier for the
<head>node.
What's next ⏩
amp-lightbox-galleryAMP layeramp-sidebaractive development- video docking active development
- Analysis of
amp-fit-text0.1->1.0auto upgrade performance implications