这是indexloc提供的服务，不要输入任何密码
Skip to content

✨ [Amp story player] [panel player] Launch panel player #35423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 23, 2021
Merged

✨ [Amp story player] [panel player] Launch panel player #35423

merged 9 commits into from
Sep 23, 2021

Conversation

processprocess
Copy link
Contributor

@processprocess processprocess commented Jul 27, 2021 •
edited
Loading

  • removes experiment flag to launch panel player
  • hides buttons when not in panel mode
  • removes desktop from variables

Closes #34765

@processprocess processprocess requested a review from gmajoulet July 27, 2021 20:42
@processprocess processprocess self-assigned this Jul 27, 2021
@processprocess processprocess changed the title ✨ [Amp story player] [Desktop panels player] Launch panel player ✨ [Amp story player] [panels player] Launch panel player Jul 28, 2021
@processprocess processprocess changed the title ✨ [Amp story player] [panels player] Launch panel player ✨ [Amp story player] [panel player] Launch panel player Jul 28, 2021
@processprocess processprocess mentioned this pull request Jul 28, 2021
Closed
@gmajoulet
Copy link
Contributor

Is there anything I can help with to merge this?

@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story-player/0.1/test/test-e2e/test-amp-story-player-prerender.js

@processprocess processprocess merged commit 457b404 into ampproject:main Sep 23, 2021
@processprocess processprocess deleted the player-buttons branch September 23, 2021 21:02
@processprocess processprocess mentioned this pull request Sep 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees

@processprocess processprocess

Labels
P1: High Priority PR use: In LTS PR use: In Stable Type: Feature Request WG: stories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amp-story-desktop-one-panel Integrate player into desktop one panel experience
3 participants
@processprocess @gmajoulet @ampprojectbot