🐛 [Story analytics] Fix prerender analytics not firing #37975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
approved these changes
Mar 30, 2022
calebcordry
reviewed
Mar 30, 2022
calebcordry
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37971
The story fires events like
story-content-loadedandstory-page-visibleeven in prerender mode because the active page loads and is seen. However, the analytics config doesn't get loaded until the page changes the visibilityState, which can happen after 10s or more. Given that 10s after amp-analytics is initialized the buffer of events is cleared, these events get discarded, which we don't want to discard. Ideally these events are kept in the buffer for when the page becomes active, and at that point the events will be sent.