这是indexloc提供的服务,不要输入任何密码
Skip to content

♻️ [Amp story shopping] Change "vendor" to "brand" #37958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

processprocess
Copy link
Contributor

Change productVendor back to productBrand.
This reverts some of the work from #37897 except productBrand is still optional.
This is to keep the field naming specific.

Note: this will need to be updated in I2Is and I2s documents.

cc @raovs

@amp-owners-bot
Copy link

Hey @gmajoulet! These files were changed:

extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.css
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-attachment.js
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-config.js
extensions/amp-story/1.0/amp-story-store-service.js

Hey @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-store-service.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants