这是indexloc提供的服务,不要输入任何密码
Skip to content

[amp story shopping] Remove multi line border radius code #37808

@processprocess

Description

@processprocess

Description

Update:
Remove the multi line border radius code. It's creating motion inconsistency, giving uneven priority to the eye. It also does not provide utility, the two line text still renders with enough room.

Removing this will create visual consistency and remove code.

Spoke with @hongcatlover and they agree.

Mar-04-2022.10-32-39.mp4
The border radius work in #37186 regressed. Using [git bisect](https://git-scm.com/docs/git-bisect), the regression was introduced in #37195. It looks like selectors were updated in CSS but not in JS of that PR. Visual diff tests were down when this regression was introduced so a diff was not triggered.

The three css selectors in styleTagText_ do not match between css and JS.
Screen Shot 2022-03-02 at 9 22 59 AM

The null checks and optional chaining can be removed since the work in #37793 runs this logic after the tag is created.

Multi-line border radius prior to regression:
Screen Shot 2022-03-02 at 9 16 56 AM

Current:
Screen Shot 2022-03-02 at 9 17 54 AM

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions