🐛 [Story attachments] Fix attachment Firebase demos #37335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the page-attachment and share-menus to be imported inline in the document on example stories so that the extensions load on Firebase.
There's a bug where
extensionsFor.installExtensionForDoc
doesn't point to the right URL for the extension on Firebase demos (it points to a URL with rtv, but it should point to thedist/
url).Relies on
upgradeCallback
, which on the documentation says: "This method is called when the element is added to DOM for the first time and beforebuildCallback
to give the element a chance to redirect its implementation to anotherBaseElement
implementation. The returned value can be eithernull
orundefined
to indicate that no redirection will take place;BaseElement
instance to upgrade immediately; or a promise to upgrade with the resolvedBaseElement
instance."Alternatives
An alternative can be to directly change the
upgradeCallback
of page-attachment and share-menu to return a promise:However, this requires all the different classes to have more repeated code.
Another alternative is to do #37331 but it's harder to follow the promise chains.