这是indexloc提供的服务，不要输入任何密码
Skip to content

🚀 [Story performance] Remove logging and development UI from the amp-story bundle #37279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 4, 2022
Merged

🚀 [Story performance] Remove logging and development UI from the amp-story bundle #37279

merged 8 commits into from
Jan 4, 2022

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented Dec 28, 2021 •
edited
Loading

We don't need the development UI as it's not being used (this is not the devtools).

dist/v0/amp-story-0.1.mjs: Δ -0.96KB
dist/v0/amp-story-1.0.mjs: Δ -0.96KB
dist/v0/amp-story-0.1.js: Δ -1.69KB
dist/v0/amp-story-1.0.js: Δ -1.69KB

@mszylkowski mszylkowski marked this pull request as ready for review January 4, 2022 16:28
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jan 4, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story-system-layer.js
extensions/amp-story/1.0/amp-story.css
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/development-ui.js
extensions/amp-story/1.0/events.js
extensions/amp-story/1.0/logging.js

@mszylkowski mszylkowski self-assigned this Jan 4, 2022
processprocess
processprocess approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@processprocess processprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mszylkowski mszylkowski merged commit ca432cf into ampproject:main Jan 4, 2022
@mszylkowski mszylkowski deleted the removeLogging branch January 4, 2022 17:02
@jshamble jshamble mentioned this pull request Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@processprocess processprocess processprocess approved these changes

Assignees

@mszylkowski mszylkowski

Labels
PR use: In Beta / Experimental PR use: In Stable WG: stories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mszylkowski @processprocess @ampprojectbot