这是indexloc提供的服务,不要输入任何密码
Skip to content

🚀 [Story performance] Remove share menu from main amp-story bundle #37235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Dec 22, 2021

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented Dec 16, 2021

Closes #37198
Closes #37206

Decreases size of amp-story by 3.32kb

@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2021

This pull request introduces 1 alert when merging 16b8153 into 03e84b4 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Dec 20, 2021

This pull request introduces 1 alert when merging 54dd432 into 38e5023 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Dec 20, 2021

This pull request introduces 1 alert when merging 15c386c into 6654c1a - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@mszylkowski mszylkowski marked this pull request as ready for review December 20, 2021 17:56
@mszylkowski mszylkowski self-assigned this Dec 20, 2021
@amp-owners-bot amp-owners-bot bot requested a review from dmanek December 20, 2021 17:56
@amp-owners-bot
Copy link

amp-owners-bot bot commented Dec 20, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-share.js
extensions/amp-story/1.0/test-e2e/test-amp-story-share-menu.js

@lgtm-com
Copy link

lgtm-com bot commented Dec 20, 2021

This pull request introduces 1 alert when merging 8ba6918 into 6654c1a - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Dec 20, 2021

This pull request introduces 1 alert when merging 6465db7 into 6654c1a - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@mszylkowski mszylkowski removed the request for review from dmanek December 20, 2021 18:45
@lgtm-com
Copy link

lgtm-com bot commented Dec 20, 2021

This pull request introduces 1 alert when merging ed8d5c6 into 6654c1a - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy load the share menu when the share icon is clicked. [Story performance] Remove share menu from amp-story into lazy-loaded bundle
4 participants