这是indexloc提供的服务,不要输入任何密码
Skip to content

🚮 [amp story 360] Remove unnecessary .then statement #36409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

processprocess
Copy link
Contributor

The promise.all resolves when the services's promises resolve.
There is no need for the additional .then.

@amp-owners-bot
Copy link

Hey @gmajoulet, @t0mg! These files were changed:

extensions/amp-story-360/0.1/amp-story-360.js

Copy link
Contributor

@mszylkowski mszylkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants