🖍 Restrict page attachment sticky header to non-iOS, non-Safari surfaces #36133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sticky positioning of the page attachment header does not work on iOS because of a known Safari issue where
position: stickyfails if a parent element hasoverflow: autoset (see caniuse). I attempted to replicate sticky positioning via JS by setting the header'sposition: fixedwhenever the sticky header was expected to be seen, but this also resulted in the header's layout being incorrectly altered.The current behavior on iOS page attachments is such that the header transitions to its sticky layout whenever the attachment reaches full height, only for the header to be scrolled out of view. We have decided that we will prevent the sticky header layout from being shown on iOS at all, until a working solution for sticky positioning has been implemented.
Before:
After:
/cc @gmajoulet
#34504
#35569