🖍 [Story performance] Added CSS rules for units, and exaple stories #36007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
reviewed
Sep 8, 2021
| --story-page-vh: 1vh; | ||
| --story-page-vmin: min(var(--story-page-vw), var(--story-page-vh)); | ||
| --story-page-vmax: max(var(--story-page-vw), var(--story-page-vh)); | ||
| --i-amphtml-story-page-50vw: calc(var(--story-page-vw) * 50); |
There was a problem hiding this comment.
The round() was really needed, but I think it was for the 3 panels desktop so hopefully we can get rid of this variable entirely.
There was a problem hiding this comment.
True, it gets removed entirely on #35932 so I'll also remove it from here, wait for that PR to merge, and then sync this branch and ensure everything is ok
|
Closing in favor of #36033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36045
In order to make the CSS provide the right values for the units, we need to encode them directly in the CSS rather than applying them from JS.
This PR sets the units to the correct size for mobile UI (fullscreen). When the story loads, the correct units will be set regardless of the UI type. We will need to set the correct units for desktop one panel UI in a future PR.
Steps (this PR is step a):
