🐛 [Story animations] Center vertical panning #38017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of github.com:ampproject/amphtml
|
Hey @gmajoulet, @newmuis! These files were changed: |
|
Awesome. It's especially noticeable with the Before: |
processprocess
approved these changes
Apr 5, 2022
|
+1, thank s for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35016
The vertical panning used to align the images too much to the left, so portrait images would be placed outside of the page.
We need to place them centered vertically, for which I updated the offsetX to match the distance we want.
I also updated the images in the demo file to be higher resolution and be more symetric so we can tell the positioning better.
Before / After:
cc @danielstockton