requiredLimits must be an ordinary JS object #4277
Description
Quoting from https://crbug.com/dawn/2025:
Notice that the following yields false:
let adapter = await navigator.gpu.requestAdapter();
let requiredLimits = adapter.limits;
let device = await adapter.requestDevice({ requiredLimits });
device.limits.maxBufferSize == requiredLimits.maxBufferSizeWhereas the following yields true:
let adapter = await navigator.gpu.requestAdapter();
let requiredLimits = {};
requiredLimits.maxBufferSize = adapter.limits.maxBufferSize;
let device = await adapter.requestDevice({ requiredLimits });
device.limits.maxBufferSize == requiredLimits.maxBufferSizeAnd indeed the following also yields true (we copy every property from adapter.limits to requiredLimits manually here):
let adapter = await navigator.gpu.requestAdapter();
let requiredLimits = {};
requiredLimits.maxBufferSize = adapter.limits.maxBufferSize;
for (const key in adapter.limits) {
requiredLimits[key] = adapter.limits[key];
}
let device = await adapter.requestDevice({ requiredLimits });
device.limits.maxBufferSize == requiredLimits.maxBufferSizeI'd expect that requesting a device using requiredLimits as adapter.limits would be fine, however requiredLimits
apparently needs to be a plain JS object (whereas adapter.limits is an instance GPUSupportedLimits).
(I was requested to repost the issue here on the Dawn issue)