-
Notifications
You must be signed in to change notification settings - Fork 345
Description
Looking at it in this CL, I don't love the name imageHeight - it's kind of confusing what it means. We can update that later in sketch.webidl though, it doesn't block this CL.
maybe imagePitchInRows? slicePitchInRows? slicePitchHeight? "slice" may sort of collide with the 2darray meaning of "slice", but that's technically correct (I think) and "image" seems worse.
Brandon Jones (Intel):
I agree. Above all I'd like consistency with rowPitch, so columnPitch?
Additionally, units should match (both in bytes, or both in texels).
rowPitchInTexels is weird because we still need to keep the 256 byte alignment and that wouldn't be possible to express for 3-byte formats if we ever support them (256 is 85.3333.. texels).
columnPitchInBytes is weird too because it has to be a multiple of rowPitchInBytes so why not just express it as columnPitchInRowPitches which is the same as columnPitchInTexels?
Anyway that's a good question, can you raise an issue / PR and we can discuss it in the next meeting.
Original discussion here