Move builtins and intrinsics out of the grammar. #655
Conversation
|
Addresses #616 |
| : LOCATION INT_LITERAL | ||
| | BUILTIN builtin_decoration | ||
| | BINDING INT_LITERAL | ||
| | SET INT_LITERAL |
There was a problem hiding this comment.
The possible values for each decoration isn't defined anywhere anymore.
There was a problem hiding this comment.
Can we not mix builtins and intrinsics together in this PR?
I don't see them being the same. The case about intrinsic functions is somewhat strong, since they are, well, functions. The case about builtins is not yet convincing to me and needs to be made first.
| : LOCATION INT_LITERAL | ||
| | BUILTIN builtin_decoration | ||
| | BINDING INT_LITERAL | ||
| | SET INT_LITERAL |
There was a problem hiding this comment.
Can we not mix builtins and intrinsics together in this PR?
I don't see them being the same. The case about intrinsic functions is somewhat strong, since they are, well, functions. The case about builtins is not yet convincing to me and needs to be made first.
|
Discussed at the 2020-04-07 meeting. |
|
Approved in meeting. |
* Move builtins and intrinsics out of the grammar. * Add valid decoration values per key.
* Move builtins and intrinsics out of the grammar. * Add valid decoration values per key.
…#655) Tests that use fragment shaders that don't write to the output must declare the color target with writeMask 0. Spec PR: gpuweb#1918 Bug: crbug.com/dawn/962
No description provided.