This repository was archived by the owner on Dec 8, 2024. It is now read-only.
Handle errors when instrumenting 'all sources' #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses an issue where the coverage report would silently fail if it attempted to instrument a file that was 'invalid' for some reason. Whilst that error once determined was easy enough to rectify (exclusion rules.) The fact that it silently exited meant it was hard to determine the cause. This change ignores any erroring files, but logs the file out to the console.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue where the coverage report would silently fail if it
attempted to instrument a file that was 'invalid' for some reason.
Whilst that error once determined was easy enough to rectify (exclusion
rules.) The fact that it silently exited meant it was hard to determine
the cause.
This change ignores any erroring files, but logs the file out to the console.