fix: stop importing sRGBEncoding constant #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since r162, three.js no longer exports the formerly deprecated sRGBEncoding constant. This replaces the import with the literal value to keep compatibility with older three.js versions until we release a new major version. fixes #1036
07ad719 to
83f403c
Compare
kwnevarez
approved these changes
Apr 26, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
* fix: stop importing sRGBEncoding constant Since r162, three.js no longer exports the formerly deprecated sRGBEncoding constant. This replaces the import with the literal value to keep compatibility with older three.js versions until we release a new major version. fixes #1036 * fix: typescript fixes for compat-code 86dc909
googlemaps-bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
### [4.0.12](v4.0.11...v4.0.12) (2024-04-26) ### Bug Fixes * stop importing sRGBEncoding constant ([#1037](#1037)) ([86dc909](86dc909)), closes [#1036](#1036) ### Miscellaneous Chores * **deps-dev:** bump core-js from 3.36.1 to 3.37.0 ([#1034](#1034)) ([822a836](822a836)) * **deps-dev:** bump rollup from 4.14.2 to 4.16.1 ([#1035](#1035)) ([d6d8601](d6d8601)) * **deps-dev:** bump typescript from 5.4.4 to 5.4.5 ([#1032](#1032)) ([272b53c](272b53c))
|
🎉 This PR is included in version 4.0.12 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since r162, three.js no longer exports the formerly deprecated sRGBEncoding constant. This replaces the import with the literal value to keep compatibility with older three.js versions until we release a new major version.
fixes #1036