这是indexloc提供的服务,不要输入任何密码
Skip to content

Make Places "textsearch" query parameter optional #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

jengel3
Copy link
Contributor

@jengel3 jengel3 commented Mar 12, 2021

The query parameter in the Places' textsearch API should be optional. Both as a fix for #395, but also more generally because the actual API supports calls without specifying the parameter.

For example: https://maps.googleapis.com/maps/api/place/textsearch/json?type=point_of_interest&location=43.8789781,-79.9714529&radius=10000&key={{ key }}

No query parameter is specified, yet the request is completed successfully with no error and a result set.

Fixes #395 🦕

@google-cla
Copy link

google-cla bot commented Mar 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 12, 2021
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #399 (d424408) into master (44cafa0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #399   +/-   ##
=======================================
  Coverage   89.19%   89.19%           
=======================================
  Files          13       13           
  Lines         731      731           
=======================================
  Hits          652      652           
  Misses         79       79           
Impacted Files Coverage Δ
googlemaps/places.py 94.21% <ø> (ø)
googlemaps/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c8feb...d424408. Read the comment docs.

@jengel3
Copy link
Contributor Author

jengel3 commented Mar 12, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 12, 2021
@jpoehnelt jpoehnelt merged commit 6b29efd into googlemaps:master Mar 12, 2021
googlemaps-bot pushed a commit that referenced this pull request Mar 12, 2021
## [4.4.4](v4.4.3...v4.4.4) (2021-03-12)

### Bug Fixes

* make Places textsearch query parameter optional ([#399](#399)) ([6b29efd](6b29efd))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

places next page token should not necessitate query
4 participants