-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make Places "textsearch" query parameter optional #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Places "textsearch" query parameter optional #399
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=======================================
Coverage 89.19% 89.19%
=======================================
Files 13 13
Lines 731 731
=======================================
Hits 652 652
Misses 79 79
Continue to review full report at Codecov.
|
@googlebot I signed it! |
## [4.4.4](v4.4.3...v4.4.4) (2021-03-12) ### Bug Fixes * make Places textsearch query parameter optional ([#399](#399)) ([6b29efd](6b29efd))
🎉 This PR is included in version 4.4.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [4.4.4](googlemaps/google-maps-services-python@v4.4.3...v4.4.4) (2021-03-12) ### Bug Fixes * make Places textsearch query parameter optional ([#399](googlemaps/google-maps-services-python#399)) ([6b29efd](googlemaps/google-maps-services-python@6b29efd))
The
query
parameter in the Places'textsearch
API should be optional. Both as a fix for #395, but also more generally because the actual API supports calls without specifying the parameter.For example:
https://maps.googleapis.com/maps/api/place/textsearch/json?type=point_of_interest&location=43.8789781,-79.9714529&radius=10000&key={{ key }}
No
query
parameter is specified, yet the request is completed successfully with no error and a result set.Fixes #395 🦕