Fixed Code Quality Issues #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
- Coverage 89.32% 89.19% -0.13%
==========================================
Files 13 13
Lines 721 731 +10
==========================================
+ Hits 644 652 +8
- Misses 77 79 +2
Continue to review full report at Codecov.
|
|
Thanks! |
googlemaps-bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
## [4.4.3](v4.4.2...v4.4.3) (2021-03-01) ### Bug Fixes * fixed code quality issues ([#398](#398)) ([44cafa0](44cafa0))
|
🎉 This PR is included in version 4.4.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Marir19950304
pushed a commit
to Marir19950304/Google_map
that referenced
this pull request
Jan 25, 2022
## [4.4.3](googlemaps/google-maps-services-python@v4.4.2...v4.4.3) (2021-03-01) ### Bug Fixes * fixed code quality issues ([#398](googlemaps/google-maps-services-python#398)) ([44cafa0](googlemaps/google-maps-services-python@44cafa0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
I ran a DeepSource Analysis on my fork of this repository. You can see all the issues raised by DeepSource here.
DeepSource helps you to automatically find and fix issues in your code during code reviews. This tool looks for anti-patterns, bug risks, performance problems, and raises issues. There are plenty of other issues in relation to Bug Discovery and Anti-Patterns which you would be interested to take a look at.
If you do not want to use DeepSource to continuously analyze this repo, I'll remove the
.deepsource.tomlfrom this PR and you can merge the rest of the fixes. If you want to setup DeepSource for Continuous Analysis, I can help you set that up.