-
Notifications
You must be signed in to change notification settings - Fork 234
Closed
Labels
api: pubsubIssues related to the googleapis/nodejs-pubsub API.Issues related to the googleapis/nodejs-pubsub API.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Re this comment: #1389 (comment)
The Node Pub/Sub library should be using a private context propagator of type W3CTraceContextPropagator
rather than the global one (which allows other libraries to stuff values that become invalid Pub/Sub attributes).
A separate issue is filed in regards to the x-cloud-trace-header
that's the proximate problem here: GoogleCloudPlatform/opentelemetry-operations-js#781
(but this library should be immune to those kinds of issues, anyway...)
the-ress
Metadata
Metadata
Assignees
Labels
api: pubsubIssues related to the googleapis/nodejs-pubsub API.Issues related to the googleapis/nodejs-pubsub API.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.