这是indexloc提供的服务,不要输入任何密码
Skip to content

fix(spanner): pointer type custom struct decoder #12496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

0daryo
Copy link
Contributor

@0daryo 0daryo commented Jun 25, 2025

Decode double pointer custom struct.
FIX #12495

@0daryo 0daryo requested review from a team as code owners June 25, 2025 04:51
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jun 25, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2025
rahul2393
rahul2393 previously approved these changes Jun 27, 2025
@0daryo 0daryo requested a review from rahul2393 June 27, 2025 07:17
@rahul2393 rahul2393 enabled auto-merge (squash) June 27, 2025 08:24
@rahul2393
Copy link
Contributor

@0daryo Can you please rebase your changes on latest main?

auto-merge was automatically disabled June 27, 2025 10:06

Head branch was pushed to by a user without write access

@0daryo 0daryo force-pushed the fix-spanner-decode-pointer-struct-custom-type branch from 57c11a9 to d3b2320 Compare June 27, 2025 10:06
@0daryo
Copy link
Contributor Author

0daryo commented Jun 27, 2025

@rahul2393

Can you please rebase your changes on latest main?

Thanks! I rebased it.

@0daryo 0daryo requested a review from rahul2393 June 27, 2025 10:15
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2025
@rahul2393 rahul2393 merged commit ac3cafb into googleapis:main Jun 27, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: DecodeSpanner is not called when using Row.ToStruct() and the target field is *T
4 participants