fix(spanner): remove stream wrapper for direct path check #12622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
reviewed
Jul 31, 2025
olavloite
previously approved these changes
Jul 31, 2025
69d0d63 to
7e326a7
Compare
olavloite
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12600
This change fixes a race condition that could occur during streaming operations in the Spanner client. The race condition was caused by concurrent access to the metrics tracer (mt) between the main execution goroutine and a background goroutine responsible for consuming stream trailers.
The fix addresses this issue by removing the wrappedStream implementation and moving the logic for updating metrics directly into the grpcSpannerClient methods (ExecuteStreamingSql, StreamingRead, and BatchWrite).
By moving the metrics-related logic out of the stream interceptor and into the gRPC client methods, the race condition is eliminated, as the metrics are now updated in the same goroutine that initiated the RPC.