fix(pubsub/pstest): message ordering issue #11603
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #11592, currently the pstest's message ordering can not be ensured because of the accuracy of using comparison by
*timestamppb.Timestamp
instead of standardtime.Time
.The solution is changing the comparison logic from proto time back to message published time.
How to test/ re-produce the error:
Since this error happens quite randomly, we can use this script to do a fuzz test. The script will fail on main branch and succeed on this fix branch.