这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(storage): dynamic read request stall timeout #10958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 14, 2024
Merged

feat(storage): dynamic read request stall timeout #10958

merged 12 commits into from
Oct 14, 2024

Conversation

raj-prince
Copy link
Contributor

@raj-prince raj-prince commented Oct 7, 2024 •
edited
Loading

  • Adding a new storage client option to enable pro-actively retry for stalled request based on dynamic timeout.
  • Added emulator test to validated the changes.

@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Oct 7, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 7, 2024
@raj-prince raj-prince mentioned this pull request Oct 7, 2024
Closed
@raj-prince raj-prince marked this pull request as ready for review October 8, 2024 18:29
@raj-prince raj-prince requested review from a team as code owners October 8, 2024 18:29
tritone
tritone reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, a few more minor points.

tritone
tritone reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more docs and defaults suggestions. Also, please follow #10984 to start an experimental package for the option.

@raj-prince raj-prince requested a review from tritone October 13, 2024 03:26
tritone
tritone reviewed Oct 14, 2024
View reviewed changes
@raj-prince raj-prince requested a review from tritone October 14, 2024 01:05
tritone
tritone approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Oct 14, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit a09f00e into googleapis:main Oct 14, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 14, 2024
@release-please release-please bot mentioned this pull request Oct 14, 2024
Merged
@raj-prince raj-prince mentioned this pull request Oct 14, 2024
Merged
@tritone tritone mentioned this pull request Oct 23, 2024
Closed
This was referenced Mar 12, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raj-prince @tritone