-
Notifications
You must be signed in to change notification settings - Fork 315
Closed
Labels
Good First IssueGood first issue for new engineersGood first issue for new engineersModule: AdSenseGoogle AdSense module related issuesGoogle AdSense module related issuesP1Medium priorityMedium priorityType: EnhancementImprovement of an existing featureImprovement of an existing feature
Milestone
Description
Bug Description
Improve the warning message when you disable placing of Adsense code on the site.
Currently it reads:
By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code.
Should be replaced with:
Please note that Adsense will not show ads on your website unless you have manually added the code.
Or something that those lines..
Steps to reproduce
- Make sure that Adsense is activated
- Go to Settings for Google Adsense (
wp-admin/admin.php?page=googlesitekit-settings#settings/adsense/edit
) - Disable the switch against
Let Site Kit place AdSense code on your site
- See the warning message that appears.
Screenshots
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The AdSense setup/settings message By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code. should be replaced with the following:
- Please note that AdSense will not show ads on your website unless you’ve already placed the code.
Implementation Brief
- Update the following text: "By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code." to "Please note that AdSense will not show ads on your website unless you’ve already placed the code." in the following files:
assets/js/modules/adsense/components/settings/SettingsForm.js
assets/js/modules/adsense/components/setup/SetupAccountApproved.js
Test Coverage
- N/A
Visual Regression Changes
- N/A
QA Brief
- Make sure that AdSense is activated
- Go to Settings for Google AdSense and disable the switch
Let Site Kit place AdSense code on your site
- Check that the warning message that appears has been updated
Changelog entry
- Clarify wording of warning message when disabling the AdSense snippet.
Metadata
Metadata
Assignees
Labels
Good First IssueGood first issue for new engineersGood first issue for new engineersModule: AdSenseGoogle AdSense module related issuesGoogle AdSense module related issuesP1Medium priorityMedium priorityType: EnhancementImprovement of an existing featureImprovement of an existing feature