这是indexloc提供的服务,不要输入任何密码
Skip to content

Improve Warning Message in Google Adsense Settings #2962

@wpdarren

Description

@wpdarren

Bug Description

Improve the warning message when you disable placing of Adsense code on the site.

Currently it reads:

By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code.

Should be replaced with:

Please note that Adsense will not show ads on your website unless you have manually added the code.

Or something that those lines..

Steps to reproduce

  1. Make sure that Adsense is activated
  2. Go to Settings for Google Adsense (wp-admin/admin.php?page=googlesitekit-settings#settings/adsense/edit)
  3. Disable the switch against Let Site Kit place AdSense code on your site
  4. See the warning message that appears.

Screenshots

image.png


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The AdSense setup/settings message By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code. should be replaced with the following:
    • Please note that AdSense will not show ads on your website unless you’ve already placed the code.

Implementation Brief

  • Update the following text: "By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code." to "Please note that AdSense will not show ads on your website unless you’ve already placed the code." in the following files:
    • assets/js/modules/adsense/components/settings/SettingsForm.js
    • assets/js/modules/adsense/components/setup/SetupAccountApproved.js

Test Coverage

  • N/A

Visual Regression Changes

  • N/A

QA Brief

  • Make sure that AdSense is activated
  • Go to Settings for Google AdSense and disable the switch Let Site Kit place AdSense code on your site
  • Check that the warning message that appears has been updated

Changelog entry

  • Clarify wording of warning message when disabling the AdSense snippet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good First IssueGood first issue for new engineersModule: AdSenseGoogle AdSense module related issuesP1Medium priorityType: EnhancementImprovement of an existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions