-
Notifications
You must be signed in to change notification settings - Fork 315
Closed
Labels
P1Medium priorityMedium priorityType: EnhancementImprovement of an existing featureImprovement of an existing feature
Milestone
Description
Feature Description
The keywords input
has no label because it renders the label
attribute on the TextField
as a placeholder
HTML attribute. This isn't accessible, so let's add a label.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- Because the
label
prop supplied to theTextField
component here is rendered as aplaceholder
, there should also be a manually-created<label>
added for theTextField
for assistive technology. Ensure there is always a<label>
tag for theTextField
with the text"Keywords (minimum one, maximum three)"
.
Implementation Brief
- edit
assets/js/components/user-input/UserInputKeywords.js
- add a
<label>
to theTextField
with the text"Keyword"
and hide it with theVisuallyHidden
component.
Test Coverage
- No tests needed for this change.
Visual Regression Changes
- VRT changes to the placeholder being empty after a value is entered might occur; otherwise none should occur.
QA Brief
- Check that the term text fields have hidden labels
Changelog entry
- Introduce hidden labels for search term fields of the User Input Settings flow.
Metadata
Metadata
Assignees
Labels
P1Medium priorityMedium priorityType: EnhancementImprovement of an existing featureImprovement of an existing feature