这是indexloc提供的服务,不要输入任何密码
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/pprof
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 813a5fb
Choose a base ref
...
head repository: google/pprof
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d1b30fe
Choose a head ref
  • 19 commits
  • 38 files changed
  • 9 contributors

Commits on Aug 27, 2024

  1. Update runner to Go 1.22,1.23 (two most recent releases). (#887)

    * Update runner to Go 1.22,1.23 (two most recent releases).
    
    * Update runner to Go 1.22,1.23 (two most recent releases).
    
    * Update Go mod to 1.22 as well.
    
    * Update staticcheck to 0.5.1 so it works with 1.23 code
    
    * Update golangci-lint to 1.60.3.
    
    v1.51 fails with errors related to old slices package.
    
    * Require Go 1.22 for bootstrapping Go tip
    
    * Github actions do not support else statements
    
    * Another attempt at Workflow syntax
    
    * Another attempt at Workflow syntax
    
    * Fix caching for Go bootstrap compiler
    
    * Fix caching for Go bootstrap compiler
    
    * Fix caching for Go bootstrap compiler
    
    * Fix caching for Go bootstrap compiler
    
    * Fix caching for Go bootstrap compiler
    
    * Fix caching for Go bootstrap compiler
    
    * Fix caching for Go bootstrap compiler
    
    * Add comments saying why we need cache directives
    ghemawat authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fa2c70b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Add doc URL to profile format and use it display help link. (#888)

    * Add doc URL to profile format and use it display help link.
    
    * Add test for Report.DocURL
    
    * Update new proto field comment
    ghemawat authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    da1f7e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Added doc link to profile header. (#892)

    Output looks something like:
    
    ```
    % pprof -top ...
    File: ...
    Build ID: ...
    Type: cpu
    Doc: http://example.com/cpuprofile
    Duration: 6.71s, Total samples = 5.72s (85.30%)
    Showing nodes accounting for 5.17s, 90.38% of 5.72s total
    Dropped 326 nodes (cum <= 0.03s)
    ...
    ```
    ghemawat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a8630ae View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Remove unnecessary symbols and add missing symbols (#893)

    Signed-off-by: cuishuang <imcusg@gmail.com>
    cuishuang authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a0b0bb1 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    e2af92c View commit details
    Browse the repository at this point in the history
  2. Display hovered box details immediately. (#897)

    Display the details (name + samples) of the currently hovered box
    above the flame graph. If no box is currently being hovered
    over, we display the total samples in the flame graph.
    
    Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
    ghemawat and aalexand authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fa3061b View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Support different display granularities in flame graph view. (#896)

    * Support different display granularities in flame graph view.
    
    Previously, flame-graph view could only display filefunctions
    granularity. We can now support all the available granularities.
    
    This allows the user to supply a granularity either via a command-line
    flag (e.g., --files), or as a URL parameter (e.g., ?g=files).
    
    Details
    * Made the default initial granularity "" so that we can stick with
      the default flame-graph granularity of "filefunctions" while also
      allowing overrides.
    * Use different computation of the list of shorter display names
      for file names (strip off leading path components instead of package
      prefixes).
    * Similarly compute color based on directory name instead of package name.
    * Include line number and column number in displayed names if the
      granularity includes line numbers.
    
    * Improve granularity entry for options command
    
    ---------
    
    Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
    ghemawat and aalexand authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d43a673 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cba816a View commit details
    Browse the repository at this point in the history
  3. Locate symbolz endpoint with deeper paths (#894)

    - `http://HOST/profilez` -> `http://HOST/symbolz`
    - `http://HOST/some/deeper/path/profilez` -> `http://HOST/some/deeper/path/symbolz`
    
    Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
    shoban and aalexand authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f3f46ee View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Use llvm-symbolizer's JSON output to provide function start lines (#891)

    * Use llvm-symbolizer's JSON output to provide function start lines
    
    When analyzing a perf.data profile converted automatically via perf_to_profile via pprof -raw perf.data, no function start lines (s=0) are present in any of the locations. With 813a5fb, this can be easily solved by using the same JSON frame data from llvm-symbolizer to provide StartLine for Function.start_line. This solves #823.
    
    * Fixed TestPEFile windows test
    
    * Fixed TestMachoFiles mac tests
    
    * Fix making sure llvm-symbolizer is available in the CI env for Linux tests
    
    Modify the `Fetch dependencies` step in `test-linux` job to include the installation of llvm. Add `Verify llvm-symbolizer installation` step to ensure that llvm-symbolizer is available in the CI environment for the Linux tests. This should resolve the test failures related to the missing llvm-symbolizer tool.
    
    * ci: Improve LLVM installation for Ubuntu 20.04 and 22.04
    
    Enhances the CI workflow to ensure proper installation of LLVM and the `llvm-symbolizer` across both Ubuntu 20.04 and 22.04 environments. These changes address the issue of an outdated llvm-symbolizer on Ubuntu 20.04, while maintaining compatibility with Ubuntu 22.04.
    
    - Add LLVM official repository for Ubuntu 20.04
    - Install LLVM 14 on Ubuntu 20.04 to ensure a recent version
    - Use update-alternatives to manage llvm-symbolizer versions
    - Maintain existing LLVM 14 for Ubuntu 22.04
    
    * ci: Make it clear that our goal is to install llvm-symbolizer
    
    ---------
    
    Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
    insilications and aalexand authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    255acd7 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Bump actions/checkout from 4.1.7 to 4.2.0 (#900)

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.0.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@692973e...d632683)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f4c0cfd View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Bump actions/checkout from 4.2.0 to 4.2.1 (#902)

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.0 to 4.2.1.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@d632683...eef6144)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1484601 View commit details
    Browse the repository at this point in the history
  2. Bump codecov/codecov-action from 4.5.0 to 4.6.0 (#901)

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
    - [Commits](codecov/codecov-action@e28ff12...b9fd7d1)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
    dependabot[bot] and aalexand authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    332c0e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. tui: use RFC3339-alike format with second precision for "Time" (#903)

    The current time format (Jan 2, 2006 at 3:04pm (MST)) has a few issues:
    
     - It displays time at minute granularity, while profiles usually have
       have second-level (and more[^go]) granularity.
     - It uses a 12-hour clock, which is tricky to handle at AM/PM
       switchovers, for people (like myself) who are not used to it. By
       contrast, a 24-hour clock is unambiguous.
     - Minor: using names for months makes it more difficult to calculate
       with time differences.
    
    Hence, I propose replacing it with an RFC3339-alike format, with spaces
    between elements for better readability.
    
    [^go]: https://github.com/golang/go/blob/3aa71c12eacd68ec16e7172d92aa5c6af32f0c3b/src/runtime/pprof/proto.go#L351
    aktau authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a352233 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Update kernel base to work for non-KASLR kernels. (#904)

    Replace an existing check for "start >= loadSegment.Vaddr" with
    "start >= 0x8000000000000000".
    
    The old condition was checking for the mapping start address to be greater
    or equal to the program segment Vaddr. However, for kernels without KASLR,
    the mapping start address (start) is less or equal the program header Vaddr.
    If the program header that includes the '.text' section is not the first
    segment, then the mapping start is strictly less than loadSegment.Vaddr.
    
    Instead of removing the condition, we replace it with a check that start is
    in the kernel address space, so we don't take this path for user space
    binaries.
    
    Adjusted the test case for PIE kernels to match actual addresses seen for
    a non-KASLR kernel. The new test fails with the old code and succeeds now.
    gmarin13 authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    017d972 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    4cf4322 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Allow symbolz to try symbolize unsymbolizable mappings. (#907)

    We added skipping unsymbolizable mappings in symbolz long time ago in
    PR #368 to address #339 where we saw error like "unexpected negative
    adjusted address".
    
    But that error was fixed in a more proper way in subsequent #397 to fix
    another reported issue #280 (and internal b/32020573). So skipping
    unsymbolized mappings shouldn't be needed anymore.
    
    I tested this by verifying that the test case from #339 still works fine
    with the proposed change. And that it does fail if I roll back #397
    locally.
    
    This change is useful as we experiment with using symbolz to symbolize
    JIT locations from //anon (which is unsymbolizable per current terminology).
    
    Co-authored-by: Maggie Nolan Edmonds <nolanmar@google.com>
    aalexand and nolanmar511 authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5986699 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Bump actions/setup-go from 5.0.2 to 5.1.0 (#909)

    Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.2 to 5.1.0.
    - [Release notes](https://github.com/actions/setup-go/releases)
    - [Commits](actions/setup-go@0a12ed9...41dfa10)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-go
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    833c56d View commit details
    Browse the repository at this point in the history
  2. Bump actions/checkout from 4.2.1 to 4.2.2 (#908)

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.1 to 4.2.2.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@eef6144...11bd719)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
    dependabot[bot] and aalexand authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d1b30fe View commit details
    Browse the repository at this point in the history
Loading