-
Notifications
You must be signed in to change notification settings - Fork 6k
Description
ExoPlayer Version
2.18.0
Devices that reproduce the issue
Any
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps
When building TrackSelectionDialogBuilder
using constructor with the Player
argument, builder does not take into account existing overrides and by default the dialog will always select Auto
option.
Expected result
In the TrackSelectionDialogBuilder
constructor it could already take available overrides from the player
instance via player.getTrackSelectionParameters().getOverrides()
instead of having empty map:
ExoPlayer/library/ui/src/main/java/com/google/android/exoplayer2/ui/TrackSelectionDialogBuilder.java
Line 111 in 03569f9
overrides = Collections.emptyMap(); |
So that you wouldn't need to explore the source code to understand why the previous selection in the dialog is not pre-selected when opening the dialog again.
Actual result
When constructing TrackSelectionDialogBuilder
the overrides are left empty and you have to know that you need to provide them manually via .setOverrides(player.getTrackSelectionParameters().getOverrides())
Media
Not applicable
Bug Report
- You will email the zip file produced by
adb bugreport
to dev.exoplayer@gmail.com after filing this issue.