-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Rollback shrinkwrap #8926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollback shrinkwrap #8926
Conversation
Summary of ChangesHello @scidomino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a critical rollback aimed at resolving release failures caused by the previous adoption of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request rolls back the use of npm-shrinkwrap.json in favor of package-lock.json, which appears to have been causing issues with the release process. The changes are mostly mechanical, replacing references to npm-shrinkwrap.json across various configuration files and scripts. The review has identified one potential issue in the .github/CODEOWNERS file where ownership is being assigned to per-package lock files that do not seem to exist in this monorepo setup. Overall, the rollback appears to be correctly implemented.
|
Size Change: -2 B (0%) Total Size: 17.3 MB ℹ️ View Unchanged
|
9be54b8 to
16c9b28
Compare
16c9b28 to
cf05eec
Compare
jacob314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLDR
Rolls back #8655, #8506, and #8298. Also updates a change in
e2e.ymlthat referenced shrinkwrap.Dive Deeper
shrinkwrap broke the release so we're rolling it back.
Reviewer Test Plan
I cut a release with this in it and verified that it fixes the release when combined with #8923 (which also broke the release).