这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@scidomino
Copy link
Collaborator

TLDR

Rolls back #8655, #8506, and #8298. Also updates a change in e2e.yml that referenced shrinkwrap.

Dive Deeper

shrinkwrap broke the release so we're rolling it back.

Reviewer Test Plan

I cut a release with this in it and verified that it fixes the release when combined with #8923 (which also broke the release).

@scidomino scidomino requested review from a team as code owners September 19, 2025 17:46
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @scidomino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a critical rollback aimed at resolving release failures caused by the previous adoption of npm-shrinkwrap.json. By reverting to package-lock.json and updating all associated configurations and scripts, the changes ensure that the project's dependency management, build, and release workflows are stable and functional, preventing future disruptions to the release pipeline.

Highlights

  • Rollback of npm-shrinkwrap.json: This pull request primarily rolls back the use of npm-shrinkwrap.json and fully transitions the project back to using package-lock.json for dependency locking, addressing issues that previously broke the release process.
  • Configuration and Workflow Updates: Various configuration files, including .github/CODEOWNERS, .prettierignore, and package.json files, have been updated to remove references to npm-shrinkwrap.json and correctly incorporate package-lock.json.
  • Script Adjustments: Several build and utility scripts, such as the publish-release GitHub action, generate-notices.js, check-lockfile.js, prepare-package.js, and version.js, have been modified to ensure they correctly interact with package-lock.json.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request rolls back the use of npm-shrinkwrap.json in favor of package-lock.json, which appears to have been causing issues with the release process. The changes are mostly mechanical, replacing references to npm-shrinkwrap.json across various configuration files and scripts. The review has identified one potential issue in the .github/CODEOWNERS file where ownership is being assigned to per-package lock files that do not seem to exist in this monorepo setup. Overall, the rollback appears to be correctly implemented.

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Size Change: -2 B (0%)

Total Size: 17.3 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.3 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Copy link
Collaborator

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@scidomino scidomino enabled auto-merge September 19, 2025 18:15
@scidomino scidomino added this pull request to the merge queue Sep 19, 2025
Merged via the queue into main with commit d0da1f5 Sep 19, 2025
23 of 25 checks passed
@scidomino scidomino deleted the tomm_unshrinkwrap branch September 19, 2025 18:25
SandyTao520 pushed a commit that referenced this pull request Sep 19, 2025
abhipatel12 pushed a commit that referenced this pull request Sep 19, 2025
anj-s pushed a commit that referenced this pull request Sep 19, 2025
nagendrareddy10 pushed a commit to nagendrareddy10/gemini-cli that referenced this pull request Sep 22, 2025
yashv6655 added a commit to yashv6655/gemini-cli that referenced this pull request Sep 22, 2025
thacio added a commit to thacio/auditaria that referenced this pull request Oct 3, 2025
giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants