-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Add footer configuration settings #7419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @miguelsolorio, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the user interface by providing granular control over the visibility of various elements displayed in the application's footer. Users can now customize their experience by choosing to hide the context summary, current working directory, sandbox status, and model information, leading to a cleaner or more focused display. This change also includes minor structural adjustments to the footer's internal layout for improved modularity.
Highlights
- New Footer Configuration Options: Introduced four new configuration settings to control the visibility of specific elements within the application's footer:
hideContextSummary,hideCWD(Current Working Directory),hideSandboxStatus, andhideModelInfo. All these settings are enabled by default, meaning the elements are visible unless explicitly hidden. - Footer Layout Refinement: The 'corgi' and error indicators in the footer have been structurally moved out of the model information container and into their own separate container, allowing for more flexible layout and conditional rendering based on the new visibility settings.
- Comprehensive Test Coverage: New unit tests have been added for both the
Appcomponent and theFootercomponent to ensure the correct behavior of the newly introduced visibility toggles, verifying that elements are hidden as expected when their respective settings are enabled.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several useful configuration options to customize the footer's visibility, allowing users to hide the CWD, sandbox status, model info, and context summary. The changes are well-implemented across the configuration schema, settings management, and UI components. The addition of corresponding tests is also appreciated.
I've found one high-severity issue in the Footer.tsx component where the logic for displaying a separator is incorrect, potentially leading to a confusing layout. My review includes a specific comment and a code suggestion to address this. Once that is fixed, this PR should be in great shape.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
jacob314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/cli/src/ui/App.tsx
Outdated
| nightly={nightly} | ||
| vimMode={vimModeEnabled ? vimMode : undefined} | ||
| isTrustedFolder={isTrustedFolderState} | ||
| hideCWD={settings.merged.ui?.hideCWD} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good news is you are using settings here as I would hope so the change to config may be revertable without any other tweaks.
jacob314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> (cherry picked from commit 0a7f5be)
TLDR
This adds configuration options for the footer to toggle certain items on/off. Everything is on by default.
Dive Deeper
This introduces the following new settings:
hideContextSummary: Hides the context summary (GEMINI.md, MCP servers) above the input.hideCWD: Hides the current working directory path in the footer.hideSandboxStatus: Hide the sandbox status indicator in the footer.hideModelInfo: Hide the model name and context usage in the footer.And also moves out corgi & errors out of the model container and places them into their own container:
Before
After
When context summary is hidden (
hideContextSummary)When CWD is hidden (
hideCWD)When sandbox is hidden (
hideSandboxStatus)When model info is hidden (
hideModelInfo)Reviewer Test Plan
Testing Matrix
Linked issues / bugs