-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Add enforcedAuthType setting #6564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
|
was looking for this feature. 👍 |
0dfc2bc to
e5e3454
Compare
|
Fixes #6257 |
|
Can you split this into a UI change and a config change? I can review the config change but @jacob314 should review the UI parts. |
|
@chrstnb if you have the auth type specified in the system level settings.json I believe that might also enforce this by default. Would you mind double checking? |
The existing selectedAuthType setting only sets a default preference, but does not limit a user from choosing a different auth type during /auth It is not used as a limiter during the /auth flow (choosing a new auth type sets a new value for selectedAuthType at user-settings level) - this behavior seems to indicate that it would be difficult to repurpose this setting for enforcement purposes. |
|
@NTaylorMullen can you say more re: #6564 (comment)? |
TLDR
This PR introduces a new setting,
enforcedAuthType, which allows system administrators to enforce a specific authentication method for the Gemini CLI.Features
enforcedAuthType, has been added to the settings schema. When this setting is present, the CLI will ensure that the user is authenticated with the specified authentication method.enforcedAuthType, the CLI will exit with an error message.enforcedAuthType, the user will be prompted to switch to the enforced authentication method.authtype.mov
Reviewer Test Plan
Testing Matrix
Linked issues / bugs
Fixes #6664