这是indexloc提供的服务，不要输入任何密码
Skip to content

chore: add type checking support for core lib #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

chore: add type checking support for core lib #50

merged 1 commit into from
Nov 5, 2025

Conversation

@lingzhong
Copy link
Collaborator

@lingzhong lingzhong commented Nov 5, 2025 •
edited
Loading

Add mypy type checker configuration to enable static type checking for the x402-a2a Python package.

Changes

  • Add mypy>=1.18.0 to lint dependency group
  • Configure mypy in pyproject.toml with strict type checking options
  • Add py.typed marker file for PEP 561 compliance

Configuration

Enabled starter mypy checks to prioritize the initial batch of type error fixes:

  • warn_unused_configs
  • warn_redundant_casts
  • warn_unused_ignores
  • strict_equality

It is intention to exclude type check from required github workflow until type check errors are resolved.

Testing

Type checking can be run with:

uv sync --group lint
uv run mypy src/x402_a2a

Current Type Check Status

Running mypy currently shows 47 type errors across 7 files. These should be addressed in follow-up PRs to maintain incremental, reviewable changes as some fixes require breaking changes.

@lingzhong lingzhong requested a review from a team as a code owner November 5, 2025 14:57
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 5, 2025

Summary of Changes

Hello @lingzhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces static type checking to the x402-a2a Python package by integrating mypy. The setup includes a strict configuration to enforce type correctness and improve code quality. This foundational change paves the way for a more robust and maintainable codebase, with existing type errors slated for resolution in subsequent, focused pull requests.

Highlights

  • Mypy Integration: Mypy, a static type checker, has been added to the project's linting dependencies to enhance code quality.
  • Strict Type Checking Configuration: Mypy is configured in pyproject.toml with strict options including warn_unused_configs, warn_redundant_casts, warn_unused_ignores, and strict_equality.
  • Dependency Lock File Update: The uv.lock file has been updated to include mypy and its dependencies (mypy-extensions, pathspec) across various Python versions and platforms.
  • Initial Type Error Report: The current status indicates 47 type errors across 7 files, which will be addressed in future, dedicated pull requests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces mypy for static type checking, which is a great step towards improving code quality and maintainability. The configuration in pyproject.toml is a good starting point. I've suggested adding a few more strictness flags to make the type checking more effective from the outset. The addition of the py.typed file for PEP 561 compliance is also correct. Overall, this is a valuable addition to the project's tooling.

@lingzhong lingzhong requested a review from jorellis November 5, 2025 15:07
@lingzhong lingzhong merged commit 0ca2ed7 into main Nov 5, 2025
5 checks passed
@lingzhong lingzhong deleted the lingzhong/typecheck branch November 5, 2025 18:38
@a2a-bot a2a-bot mentioned this pull request Nov 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorellis jorellis jorellis approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lingzhong @jorellis