这是indexloc提供的服务,不要输入任何密码
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-cocoa
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8.7.1
Choose a base ref
...
head repository: getsentry/sentry-cocoa
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8.7.2
Choose a head ref
  • 7 commits
  • 22 files changed
  • 6 contributors

Commits on May 15, 2023

  1. Merge branch 'release/8.7.1'

    getsentry-bot committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b7bd719 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f938d24 View commit details
    Browse the repository at this point in the history
  3. ci: Remove schedule of unit tests (#3030)

    We hypothesized that tests take longer and fail more often when the US is
    online. We didn't find strong evidence for this claim. There could be a slight
    correlation between the US being online and the tests failing more often.
    Even with a weak correlation, there isn't much we can do except improve the
    test suite. Therefore, keeping the tests running on a schedule doesn't make
    sense.
    philipphofmann authored May 15, 2023
    Configuration menu
    Copy the full SHA
    aeec206 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Configuration menu
    Copy the full SHA
    a54df45 View commit details
    Browse the repository at this point in the history
  2. fix: A crash for user interaction transactions (#3036)

    Finishing multiple spans on different threads that cancel and
    reschedule the idle timeout for user interaction transactions
    could lead to EXC_BAD_ACCESS crashes. This is fixed now by
    synchronizing the access to the idleTimeout block.
    
    Fixes GH-3002
    philipphofmann authored May 16, 2023
    Configuration menu
    Copy the full SHA
    2719ce6 View commit details
    Browse the repository at this point in the history
  3. fix: additional profiling data races (#3035)

    In #3018, there was a change to add locking where `processBacktrace` mutated data structures that could be accessed concurrently. It attempted to separate the code that did not access the shared data structures, and moved all mutating code to a section at the end of the function. However, it missed a few reads from those data structures that also needed to be synchronized (e.g. `frames.count` and `stacks.count`). Generally, separating the critical section from the rest of the logic in that function is not worth the pain because the taking the lock for the entire duration of the function is not expensive.
    
    This refactor adds a new type, `SentryProfilingState`, that centralizes all logic for reading/writing the shared data structures. This has the additional benefit that you no longer need a `processBacktrace` function that takes many parameters where the lifetime of those parameters is unclear (this will be helpful for fixing the memory leaks in a subsequent PR).
    
    ---------
    
    Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
    indragiek and getsentry-bot authored May 16, 2023
    Configuration menu
    Copy the full SHA
    cd39d58 View commit details
    Browse the repository at this point in the history
  4. release: 8.7.2

    getsentry-bot committed May 16, 2023
    Configuration menu
    Copy the full SHA
    8dab665 View commit details
    Browse the repository at this point in the history
Loading