-
-
Notifications
You must be signed in to change notification settings - Fork 372
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: getsentry/sentry-cocoa
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8.7.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: getsentry/sentry-cocoa
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8.7.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 22 files changed
- 6 contributors
Commits on May 15, 2023
-
getsentry-bot committed
May 15, 2023 Configuration menu - View commit details
-
Copy full SHA for b7bd719 - Browse repository at this point
Copy the full SHA b7bd719View commit details -
Configuration menu - View commit details
-
Copy full SHA for f938d24 - Browse repository at this point
Copy the full SHA f938d24View commit details -
ci: Remove schedule of unit tests (#3030)
We hypothesized that tests take longer and fail more often when the US is online. We didn't find strong evidence for this claim. There could be a slight correlation between the US being online and the tests failing more often. Even with a weak correlation, there isn't much we can do except improve the test suite. Therefore, keeping the tests running on a schedule doesn't make sense.
Configuration menu - View commit details
-
Copy full SHA for aeec206 - Browse repository at this point
Copy the full SHA aeec206View commit details
Commits on May 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a54df45 - Browse repository at this point
Copy the full SHA a54df45View commit details -
fix: A crash for user interaction transactions (#3036)
Finishing multiple spans on different threads that cancel and reschedule the idle timeout for user interaction transactions could lead to EXC_BAD_ACCESS crashes. This is fixed now by synchronizing the access to the idleTimeout block. Fixes GH-3002
Configuration menu - View commit details
-
Copy full SHA for 2719ce6 - Browse repository at this point
Copy the full SHA 2719ce6View commit details -
fix: additional profiling data races (#3035)
In #3018, there was a change to add locking where `processBacktrace` mutated data structures that could be accessed concurrently. It attempted to separate the code that did not access the shared data structures, and moved all mutating code to a section at the end of the function. However, it missed a few reads from those data structures that also needed to be synchronized (e.g. `frames.count` and `stacks.count`). Generally, separating the critical section from the rest of the logic in that function is not worth the pain because the taking the lock for the entire duration of the function is not expensive. This refactor adds a new type, `SentryProfilingState`, that centralizes all logic for reading/writing the shared data structures. This has the additional benefit that you no longer need a `processBacktrace` function that takes many parameters where the lifetime of those parameters is unclear (this will be helpful for fixing the memory leaks in a subsequent PR). --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
Configuration menu - View commit details
-
Copy full SHA for cd39d58 - Browse repository at this point
Copy the full SHA cd39d58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dab665 - Browse repository at this point
Copy the full SHA 8dab665View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 8.7.1...8.7.2