这是indexloc提供的服务,不要输入任何密码
Skip to content

Update top bar icons #8134

@helin24

Description

@helin24

I was working on this but noticed some complications in trying to change over to the new SVGs (from font icons):

  • lib/src/shared/screen.dart is the file defining icons for each page as a ScreenMetaData
  • ScreenMetaData expects icon to be IconData. I thought the icon font was being used in navigation, but actually this is only for within tests. So potentially if switchToScreen in tests (e.g. in integration_test/test/live_connection/memory_screen_helpers.dart) can be done with some other mechanism, then this won't be a difficult change.
  • The other change needed is for Screen to take an icon directly

Metadata

Metadata

Assignees

Labels

P1high priority issues at the top of the work list, actively being worked on.cost: lowLow engineering cost to implement.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions