-
Notifications
You must be signed in to change notification settings - Fork 345
Closed
Labels
P1high priority issues at the top of the work list, actively being worked on.high priority issues at the top of the work list, actively being worked on.cost: lowLow engineering cost to implement.Low engineering cost to implement.
Description
I was working on this but noticed some complications in trying to change over to the new SVGs (from font icons):
lib/src/shared/screen.dart
is the file defining icons for each page as aScreenMetaData
ScreenMetaData
expects icon to beIconData
. I thought the icon font was being used in navigation, but actually this is only for within tests. So potentially ifswitchToScreen
in tests (e.g. inintegration_test/test/live_connection/memory_screen_helpers.dart
) can be done with some other mechanism, then this won't be a difficult change.- The other change needed is for
Screen
to take an icon directly
Metadata
Metadata
Assignees
Labels
P1high priority issues at the top of the work list, actively being worked on.high priority issues at the top of the work list, actively being worked on.cost: lowLow engineering cost to implement.Low engineering cost to implement.