Cache get-benchmarks #494
Merged
Cache get-benchmarks #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
reviewed
Oct 28, 2019
app_dart/bin/server.dart
Outdated
| @@ -47,7 +47,12 @@ Future<void> main() async { | |||
| '/api/debug/reset-pending-tasks': DebugResetPendingTasks(config, authProvider), | |||
|
|
|||
| '/api/public/build-status': GetBuildStatus(config), | |||
| '/api/public/get-benchmarks': GetBenchmarks(config), | |||
| '/api/public/get-benchmarks': CacheRequestHandler<Body>( | |||
| cache: await cacheService.redisCache(), | |||
There was a problem hiding this comment.
You're calling await cacheService.redisCache() twice -- can you store it as a local variable and reuse it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #484, this caches the endpoint that returns all the time series history for the different benchmarks. Currently, it takes ~37 seconds to return, and this will bring it to under a second when returning from cache.
Future Work
get-timeseries-historyendpoint, but we need to move the POST parameter to GET params.CacheRequestHandlerstores responses by the URI and query parameters, and does not use the POST body.