-
Notifications
You must be signed in to change notification settings - Fork 29.5k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: c2739f0dcc39
head repository: flutter/flutter
compare: 9c626d9f9afa
- 18 commits
- 89 files changed
- 10 contributors
Commits on Jul 16, 2025
-
[web] Remove all usages of js_util. (#171871)
Closes #143396 ### Description - Removes `js_util` library usage across the codebase In order to get rid of `dart.library.js_util` in [`kIsWeb`](https://github.com/flutter/flutter/blob/e8d56b25c039666e1040c22ac36cfa3550be58cf/packages/flutter/lib/src/foundation/constants.dart#L83) constant the dart analyzer has to be updated first. For now, the `dart.library.js_util` value is hardcoded in the source code: https://github.com/dart-lang/sdk/blob/1a88edceb75f70490827ef845586bf549d5f05b0/pkg/analyzer/lib/src/dart/constant/evaluation.dart#L2908-L2915. So we either have to update this value or wait for the dart-lang/sdk#50045 fix. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for 66281ce - Browse repository at this point
Copy the full SHA 66281ceView commit details -
Roll Skia from 59be8479c637 to bf3f9b77d3a8 (7 revisions) (#172233)
https://skia.googlesource.com/skia.git/+log/59be8479c637..bf3f9b77d3a8 2025-07-16 kjlubick@google.com Copy version.js instead of install due to symlinks 2025-07-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dd4d30b3bfd0 to d28110d62aa4 (5 revisions) 2025-07-16 robertphillips@google.com [graphite] Move Android PrecompileSettings to their own file 2025-07-16 michaelludwig@google.com [graphite] Allow ClipStack to modify draw geometry 2025-07-16 kjlubick@google.com Fix/diagnose missing bazel paths in skottie-final 2025-07-16 mike@reedtribe.org change generatePath() to return optional<GeneratedPath> 2025-07-16 lukasza@chromium.org [rust png] Gracefully handle input stream that shrinks over time (reland). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jlavrova@google.com,jsimmons@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for cfa7e33 - Browse repository at this point
Copy the full SHA cfa7e33View commit details -
Use
release-*.versionto simplifylast_engine_commit.sh(no branc…Configuration menu - View commit details
-
Copy full SHA for 0669195 - Browse repository at this point
Copy the full SHA 0669195View commit details -
[skwasm] Decrease reliance on finalizers/GC (#172187)
Some changes which make Skwasm less dependent on GC cycles to free its native resources: * Explicitly clean up pictures clipped by the scene view * Free native `ParagraphBuilder` when `build()` is called * Restructure `TextStyle`, `ParagraphStyle`, `StrutStyle` and `LineMetrics` so that they don't persistently hang on to native objects beyond a paragraph build cycle. This addresses #170889
Configuration menu - View commit details
-
Copy full SHA for 97ad45a - Browse repository at this point
Copy the full SHA 97ad45aView commit details -
Marks Linux_pixel_7pro integration_ui_driver to be unflaky (#172213)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux_pixel_7pro integration_ui_driver" } --> The issue #167638 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20integration_ui_driver%22). This test can be marked as unflaky.Configuration menu - View commit details
-
Copy full SHA for b9d2459 - Browse repository at this point
Copy the full SHA b9d2459View commit details -
Fix use of
Join-Pathinlast_engine_commit.ps1(poweshell) (#172242)It worked on the Mac version of Powershell (`pwsh`) but [not on the Windows bots](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8709168939844960513/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout): ```txt 00:09 +37 ~2 -3: C:/b/s/w/ir/x/w/flutter/dev/tools/test/last_engine_commit_test.dart: returns the last engine commit [E] Failed running "powershell [C:\b\s\w\ir\x\t\last_engine_commit_test.88f44c9f\flutter\bin\internal\last_engine_commit.ps1]" (exit code = 1), stdout: stderr: Join-Path : A positional parameter cannot be found that accepts argument 'internal'. At C:\b\s\w\ir\x\t\last_engine_commit_test.88f44c9f\flutter\bin\internal\last_engine_commit.ps1:29 char:35 + ... SION_PATH = Join-Path $gitToplevel "bin" "internal" "release-candidat ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidArgument: (:) [Join-Path], ParentContainsErrorRecordException + FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.PowerShell.Commands.JoinPathCommand ``` ... this looks safer, I'll make sure it passes pre-subs this time.
Configuration menu - View commit details
-
Copy full SHA for 90b655f - Browse repository at this point
Copy the full SHA 90b655fView commit details -
Roll Dart SDK from 766ee8029b11 to d71df90177e4 (1 revision) (#172243)
https://dart.googlesource.com/sdk.git/+log/766ee8029b11..d71df90177e4 2025-07-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.10.0-5.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for c2ce002 - Browse repository at this point
Copy the full SHA c2ce002View commit details -
Remove dead link in the doc index. (#172240)
That page doesn't seem to exist in the repo anymore.
Configuration menu - View commit details
-
Copy full SHA for 0989a87 - Browse repository at this point
Copy the full SHA 0989a87View commit details -
Properly lay out and position RenderWebImage (#171916)
Fixes #163288 Fixes #164405 The previous behavior of `RenderWebImage` for layout and positioning did not work for all values of `BoxFit` and `AlignmentGeometry`. This PR gets `RenderWebImage` to properly lay out and offset its child (the `<img>` element). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for 97aae2a - Browse repository at this point
Copy the full SHA 97aae2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 323b45e - Browse repository at this point
Copy the full SHA 323b45eView commit details -
Roll Skia from bf3f9b77d3a8 to 3ad1aace3e02 (11 revisions) (#172255)
https://skia.googlesource.com/skia.git/+log/bf3f9b77d3a8..3ad1aace3e02 2025-07-16 bungeman@google.com Update clang and iwyu for Linux 2025-07-16 kjlubick@google.com Make borenet@ and kjlubick@ OWNERS of include/*.bzl files 2025-07-16 lukasza@chromium.org Reapply "[rust png] Extra verification of dimensions of the first `fcTL` chunk." 2025-07-16 mike@reedtribe.org More uses of pathbuilder instead of path 2025-07-16 mike@reedtribe.org change getPath() to return optional 2025-07-16 lehoangquyen@chromium.org GraphiteDawn: use push constants. 2025-07-16 michaelludwig@google.com Increase tolerances for BigImageTest slightly 2025-07-16 mike@reedtribe.org Oops -- false does not map to {} -- it mapped to 0 2025-07-16 kjlubick@google.com Fix path in build.sh 2025-07-16 michaelludwig@google.com [graphite] Snap scissor rects to 4px boundaries 2025-07-16 robertphillips@google.com [graphite] Migrate RenderPassProperties out of PrecompileTestUtils.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jlavrova@google.com,jsimmons@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for b7b183c - Browse repository at this point
Copy the full SHA b7b183cView commit details -
Remove emoji from ci.yaml, because we still live with CP1252 for some…
… silly reason (#172256) WARNING: codefu's snark level is approaching maximums.
Configuration menu - View commit details
-
Copy full SHA for 318a228 - Browse repository at this point
Copy the full SHA 318a228View commit details
Commits on Jul 17, 2025
-
Adds more data to licenses_cpp. There are no missing copyrights after this PR. There is one workaround for the boost license since it is split across multiple comments, which isn't yet supported. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for c0f1279 - Browse repository at this point
Copy the full SHA c0f1279View commit details -
Perform OpenGL compositing in the Flutter thread and write to a frame…
…buffer. (#172090) This framebuffer then gets copied into GTK during the draw calls. This disconnects the Flutter rendering from the GTK rendering which will allow us to render Flutter using EGL directly and support rendering without any views present (required for multi-window). Framebuffers are shared between the Flutter and GTK OpenGL contexts using EGLImage. When running under X11 GTK uses GLX and this is not possible - instead the buffers are copied via the CPU in this case.
Configuration menu - View commit details
-
Copy full SHA for e983e59 - Browse repository at this point
Copy the full SHA e983e59View commit details -
Roll Skia from 3ad1aace3e02 to 5b4afa58289a (3 revisions) (#172264)
https://skia.googlesource.com/skia.git/+log/3ad1aace3e02..5b4afa58289a 2025-07-16 jlavrova@google.com Fixing chrome roll 2025-07-16 kjlubick@google.com Add script to tag docker images built on Louhi 2025-07-16 robertphillips@google.com [graphite] Move Android-specific PaintOptions into AndroidPaintOptions.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jlavrova@google.com,jsimmons@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for aa4bdc9 - Browse repository at this point
Copy the full SHA aa4bdc9View commit details -
Roll Dart SDK from d71df90177e4 to 486f9c0663bc (1 revision) (#172269)
https://dart.googlesource.com/sdk.git/+log/d71df90177e4..486f9c0663bc 2025-07-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.10.0-6.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 26070a3 - Browse repository at this point
Copy the full SHA 26070a3View commit details -
Roll Fuchsia Linux SDK from JRFUXSNXExcfjVYvA... to HXdm7P0a4ZJVm_TE-…
…... (#172268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 8d3888c - Browse repository at this point
Copy the full SHA 8d3888cView commit details -
Roll Skia from 5b4afa58289a to 3673a1f26a63 (1 revision) (#172274)
https://skia.googlesource.com/skia.git/+log/5b4afa58289a..3673a1f26a63 2025-07-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jlavrova@google.com,jsimmons@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 9c626d9 - Browse repository at this point
Copy the full SHA 9c626d9View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff c2739f0dcc39...9c626d9f9afa