-
Notifications
You must be signed in to change notification settings - Fork 29.5k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: b3fb4c786d80
head repository: flutter/flutter
compare: 2265d94c6b0b
- 7 commits
- 4 files changed
- 3 contributors
Commits on Aug 18, 2025
-
Roll Dart SDK from a874859559e6 to 502455ee300b (1 revision) (#173934)
https://dart.googlesource.com/sdk.git/+log/a874859559e6..502455ee300b 2025-08-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.10.0-107.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 59ecc77 - Browse repository at this point
Copy the full SHA 59ecc77View commit details -
Roll Skia from 88e8c099a086 to 978726c1e725 (3 revisions) (#173935)
https://skia.googlesource.com/skia.git/+log/88e8c099a086..978726c1e725 2025-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0ae104d9374d to eb3190110845 (1 revision) 2025-08-17 mike@reedtribe.org Reapply "Factor out common pathiter" 2025-08-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC chinmaygarde@google.com,fmalita@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 51eb659 - Browse repository at this point
Copy the full SHA 51eb659View commit details -
Enhance FilledButton and Theme Data's documentation to clarify platfo…
…rm-specific visual density behavior (#173695) - Fix #155768 - Description: The issue is not a bug but WAI, it's due to visual density not being the same on each platform by default (see my full explanation at [here](#155768 (comment))), see: https://github.com/flutter/flutter/blob/f22787193bcca7c1455f29e1ed4fd15215a736d5/packages/flutter/lib/src/material/theme_data.dart#L3250-L3255 - This is LOCs where visual density impacts the padding: https://github.com/flutter/flutter/blob/a04fb324be734cf18811c30c06baf9bf07b3bab3/packages/flutter/lib/src/material/button_style_button.dart#L501-L505 In this PR: - Add `Visual density effects` section to FilledButton documentation to avoid confusion for users - Improve the documentation for `VisualDensity.defaultDensityForPlatform` by including detailed information about the specific density for each platform. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Signed-off-by: huycozy <huy@nevercode.io>
Configuration menu - View commit details
-
Copy full SHA for b1551a1 - Browse repository at this point
Copy the full SHA b1551a1View commit details -
Roll Fuchsia Linux SDK from sLmXksm1vZl2VEeA7... to n0EnLlotF2wczlOq_…
…... (#173936) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for a8faac8 - Browse repository at this point
Copy the full SHA a8faac8View commit details -
Roll Skia from 978726c1e725 to 3a17208059ec (2 revisions) (#173939)
https://skia.googlesource.com/skia.git/+log/978726c1e725..3a17208059ec 2025-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 951c83390400 to d3e0a508e29c 2025-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 74f9e2cd8bc1 to c4343b58423e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC chinmaygarde@google.com,fmalita@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 660c234 - Browse repository at this point
Copy the full SHA 660c234View commit details -
Roll Skia from 3a17208059ec to 07d71ea4d056 (4 revisions) (#173942)
https://skia.googlesource.com/skia.git/+log/3a17208059ec..07d71ea4d056 2025-08-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b639f97ad620 to 2c53c1b75e06 (5 revisions) 2025-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 5e22a60082ec to 0b85ebb8cd88 2025-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 986ca4affc81 to 6943b399ac36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC chinmaygarde@google.com,fmalita@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 78df185 - Browse repository at this point
Copy the full SHA 78df185View commit details -
Remove
embedded_android_views(on-device) tests, same as emulator t……est (#173814) These tests are identical to the `Linux_android_emu` test that runs on presubmit: https://github.com/flutter/flutter/blob/9583f282a50f88a269f5716f1ecfe42f6b6387a3/.ci.yaml#L408-L416 These tests do not report benchmarks or any other statistics that would benefit from a real (on-device) test.
Configuration menu - View commit details
-
Copy full SHA for 2265d94 - Browse repository at this point
Copy the full SHA 2265d94View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff b3fb4c786d80...2265d94c6b0b