这是indexloc提供的服务,不要输入任何密码
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d2ac0210ee05
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 26bb33b9572b
Choose a head ref
  • 20 commits
  • 90 files changed
  • 13 contributors

Commits on Aug 21, 2025

  1. Revert "Update the AccessibilityPlugin::Announce method to account fo… (

    #174223)
    
    …r the view (#172669)"
    
    This reverts commit e131243.
    
    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->
    
    pr causes internal breakage
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    chunhtai authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    8632719 View commit details
    Browse the repository at this point in the history
  2. Report a correct display ID in the window metrics event on win32 (#17…

    …4156)
    
    ## What's new?
    Now that we're sending down "true" display information to the framework,
    we also need to send down the correct display id in the
    WindowMetricsEvent for the view so that the display resolves properly.
    This pull request adds that :)
    
    ## How to test
    Here's a silly app that makes sure that our `Display` is legit:
    
    ```dart
    // Copyright 2014 The Flutter Authors. All rights reserved.
    // Use of this source code is governed by a BSD-style license that can be
    // found in the LICENSE file.
    
    import 'package:flutter/widgets.dart';
    
    void main() => runApp(W());
    
    class W extends StatelessWidget {
      @OverRide
      Widget build(BuildContext context) {
        final x = View.of(context);
        print(x.display.id);
        return const Center(
          child: Text('Hello, world!', key: Key('title'), textDirection: TextDirection.ltr),
        );
      }
    }
    ```
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    mattkae authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    4d4a69f View commit details
    Browse the repository at this point in the history
  3. Use an alternative to git describe for master version resolution (#…

    …174088)
    
    Closes #173904.
    
    It's not clear to me how `git describe --tags HEAD` ever ... worked to
    determine a fallback. From what I can tell, the _intent_ was to use the
    latest (newest? closest?) tag as the base version, and then append
    `-{commitCount}-{shortHash}` as the fallback version number when on
    `master` (or any non-published branch).
    
    So, I rewrote the implementation, unfortunately with 4 separate calls
    out to `git ...` instead of a single one.
    
    There are 20+ tests that fail as a result of this change, mostly because
    they make specific expectations around `git describe` being invoked, and
    of course that is no longer the case - putting those aside, I'd like to
    double check that:
    
    1. I understand what the original command was _intending_ to do
    2. We like the _output_ of the updated command
    3. ... we either are okay with the implementation, or have an
    alternative in mind (I'm no `git` master)
    
    Wdyt?
    
    At this commit:
    ```sh
    $ flutter-dev --version                                                            
    Flutter 3.36.0-1.0.pre-170 • channel [user-branch] • https://github.com/matanlurey/flutter
    Framework • revision 250381a (5 minutes ago) • 2025-08-19 18:57:36 -0700
    Engine • hash f278b0aa3b8c6732ab636563eb8e896c35fc9c79 (revision 9ac4fac) (2 hours ago) • 2025-08-19 23:42:28.000Z
    Tools • Dart 3.10.0 (build 3.10.0-115.0.dev) • DevTools 2.49.0
    ```
    
    /cc @zanderso @jmagman for historics.
    matanlurey authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    e45fd36 View commit details
    Browse the repository at this point in the history
  4. [ Tool ] Cleanup widget preview and frontend server shutdown (#173863)

    Prevents the frontend server from throwing ToolExit with the "The Dart
    compiler exited unexpectedly." on shutdown via a signal.
    bkonyi authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    1949846 View commit details
    Browse the repository at this point in the history
  5. Roll Dart SDK from 0d0a0c394381 to c153c5259e62 (7 revisions) (#174227)

    https://dart.googlesource.com/sdk.git/+log/0d0a0c394381..c153c5259e62
    
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-125.0.dev
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-124.0.dev
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-123.0.dev
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-122.0.dev
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-121.0.dev
    2025-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-120.0.dev
    2025-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-119.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter
    Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
    ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    6b12805 View commit details
    Browse the repository at this point in the history
  6. [ Tool ] Throw ToolExit when asset entries use absolute paths (#174230

    )
    
    Our documentation states that "the value of an asset is a relative path
    from the pubspec.yaml file", but this was never actually verified by the
    tool. On systems with POSIX semantics, this would simply result in
    invalid asset paths being built, but on Windows this could cause an
    exception to be thrown as the built URI would not be a valid `file://`
    URI.
    
    This change adds checks to ensure that asset paths are relative and that
    they are valid file paths.
    
    Fixes #173405
    bkonyi authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    d88140f View commit details
    Browse the repository at this point in the history
  7. Roll Dart SDK from 0d0a0c394381 to c153c5259e62 (7 revisions) (#174235)

    https://dart.googlesource.com/sdk.git/+log/0d0a0c394381..c153c5259e62
    
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-125.0.dev
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-124.0.dev
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-123.0.dev
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-122.0.dev
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-121.0.dev
    2025-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-120.0.dev
    2025-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-119.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter
    Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
    ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    aeb2b12 View commit details
    Browse the repository at this point in the history
  8. Roll Skia from 721e68fe652a to c09589f7ca69 (12 revisions) (#174162)

    https://skia.googlesource.com/skia.git/+log/721e68fe652a..c09589f7ca69
    
    2025-08-20 nicolettep@google.com Add instructions to trigger newly-added
    tryjobs
    2025-08-20
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
    vulkan-deps from 607fb6b15ab2 to 9d3db2fa8a2f (5 revisions)
    2025-08-20 bungeman@google.com Properly handle value types in LRUCache
    2025-08-20 syoussefi@google.com Skip ImageBackendTextureTest on
    protected contexts
    2025-08-20 fmalita@google.com [skcms] Update SHA to reflect actual
    roller state
    2025-08-20 thomsmit@google.com [graphite] Bubble up opacity in paint
    params.
    2025-08-20 syoussefi@google.com [graphite][vulkan] Enable skipped
    BackendTextureTests
    2025-08-20 michaelludwig@google.com [skif] Adjust overscaling logic for
    periodic tiling
    2025-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
    from ff95cc93afac to dc24ecca9ed9 (4 revisions)
    2025-08-20
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-08-20
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    8700465 View commit details
    Browse the repository at this point in the history
  9. [ Widget Preview ] Fix crash when attempting to provide non-const par…

    …ams to a `Preview` (#174242)
    
    Instead of crashing, invalid previews should just be ignored.
    
    Fixes #173710
    bkonyi authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    c326541 View commit details
    Browse the repository at this point in the history
  10. Update .gemini/styleguide.md to encourage master-only (#174065)

    No idea if this will work.
    matanlurey authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    f79602d View commit details
    Browse the repository at this point in the history
  11. Improve xcresult comment and naming (#173129)

    The function `_parseIssuesFromNewFormat` is renamed to
    `_parseIssuesFromXcode16Format`. The term "new" is relative and would
    become obsolete on the next format change, forcing a rename. The new
    name is specific and stable.
    
    
    Fixes #172596 
    
    *If you had to change anything in the [flutter/tests] repo, include a
    link to the migration guide as per the [breaking change policy].*
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [X] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [X] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    ---------
    
    Co-authored-by: Jenn Magder <magder@google.com>
    okorohelijah and jmagman authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    45f8c32 View commit details
    Browse the repository at this point in the history
  12. [ Widget Preview ] Add regression test for issue 173895 (#174037)

    Should have been included in
    #173987
    
    ---------
    
    Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
    bkonyi and gemini-code-assist[bot] authored Aug 21, 2025
    Configuration menu
    Copy the full SHA
    9bf6e26 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2025

  1. Roll Skia from c09589f7ca69 to d70087007490 (22 revisions) (#174245)

    https://skia.googlesource.com/skia.git/+log/c09589f7ca69..d70087007490
    
    2025-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
    vulkan-deps from db9c62a65630 to 7e28c4c2f184 (10 revisions)
    2025-08-21 ccameron@chromium.org HDR v2: Change
    SkNamedTransferFn::kHLG/kPQ to new version
    2025-08-21 drafting@samizdat.co Fix SkOrderedFontMgr::onMatchFamily
    2025-08-21
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-08-21 jmbetancourt@google.com [capture] record and collect SKPs in
    the CaptureManager during capture
    2025-08-21 alexandre_mutel@live.com Add support for configuring font
    edging/hinting/subpixel to SkParagraph
    2025-08-21 bungeman@google.com Update MODULE.bazel.lock
    2025-08-21 bungeman@google.com Update cxx to 1.0.168
    2025-08-21 bungeman@google.com Improve simple containers
    2025-08-21 drott@chromium.org [Fontations] Roll Fontations
    2025-08-21 fmalita@google.com Skip SurfaceBackendTextureTest on
    protected contexts
    2025-08-21
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
    from 555275f0c242 to 518c3165422f (29 revisions)
    2025-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
    vulkan-deps from 9d3db2fa8a2f to db9c62a65630 (2 revisions)
    2025-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
    from dc24ecca9ed9 to 995c4c4d89ed (6 revisions)
    2025-08-21
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
    SwiftShader from a1b94a283161 to 5b45bdb479fa (1 revision)
    2025-08-21
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-08-21
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms
    from 238fd0489c04 to c602c137fb05 (1 revision)
    2025-08-20 syoussefi@google.com [vulkan] Add a way to disable
    VK_EXT_graphics_pipeline_library
    2025-08-20 michaelludwig@google.com [graphite] Add parentheses to
    silence warning
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    47b253f View commit details
    Browse the repository at this point in the history
  2. Roll Skia from d70087007490 to 006241a7fbe1 (2 revisions) (#174252)

    https://skia.googlesource.com/skia.git/+log/d70087007490..006241a7fbe1
    
    2025-08-22
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-08-22
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    d9a597e View commit details
    Browse the repository at this point in the history
  3. Roll Dart SDK from c153c5259e62 to 4f9623f024ab (2 revisions) (#174250)

    https://dart.googlesource.com/sdk.git/+log/c153c5259e62..4f9623f024ab
    
    2025-08-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-127.0.dev
    2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.10.0-126.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter
    Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
    ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    d78cb7f View commit details
    Browse the repository at this point in the history
  4. Skip wasm build when dry run is disabled and --wasm is not specified. (

    …#174184)
    
    This fixes an issue where the wasm build was still getting executed when
    `--no-wasm-dry-run` was specified.
    
    Also adds a test to verify the expected behavior.
    
    Co-authored-by: Nate Biggs <natebiggs@google.com>
    biggs0125 and natebiggs authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    2b82bc9 View commit details
    Browse the repository at this point in the history
  5. Roll Skia from 006241a7fbe1 to 75fef9fb3ed7 (1 revision) (#174254)

    https://skia.googlesource.com/skia.git/+log/006241a7fbe1..75fef9fb3ed7
    
    2025-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
    from 518c3165422f to af771226e2ea (18 revisions)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    ac7a1f0 View commit details
    Browse the repository at this point in the history
  6. Roll Skia from 75fef9fb3ed7 to cb15e1452399 (1 revision) (#174255)

    https://skia.googlesource.com/skia.git/+log/75fef9fb3ed7..cb15e1452399
    
    2025-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
    from 995c4c4d89ed to d0ba2fb9305a (5 revisions)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    86281c3 View commit details
    Browse the repository at this point in the history
  7. Migrate more files to use WidgetStateProperty (#174176)

    Follow up of #174109
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    ValentinVignal authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    7130981 View commit details
    Browse the repository at this point in the history
  8. [HCPP] Clean up overlay layer when last frame had overlay content and…

    … current doesn't (#173881)
    
    Fixes #173635
    
    My current understanding of the issue is that we are never pushing a new
    empty frame for this layer, so the texture gets stuck as shown in the
    bug. If we keep track of when we had content last frame, and don't in
    the current frame, we can push a single empty frame for that layer when
    needed.
    
    See example in
    #173635 (comment)
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    ---------
    
    Co-authored-by: Gray Mackall <mackall@google.com>
    gmackall and Gray Mackall authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    26bb33b View commit details
    Browse the repository at this point in the history
Loading