这是indexloc提供的服务,不要输入任何密码
Skip to content

fix(firestore, ios): fix an issue where unlimited cache wasn't properly set on iOS #17412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Jun 6, 2025

Description

We were setting the same number as Android instead of using the correct variable from iOS.
We have no way to test garbage collecting currently.

Related Issues

closes #12315

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone merged commit cad2840 into main Jun 6, 2025
28 of 31 checks passed
@Lyokone Lyokone deleted the fix/12315 branch June 6, 2025 08:18
@firebase firebase locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] garbage collector triggered when CACHE_SIZE_UNLIMITED is set on iOS
3 participants