fix(firestore, web): stop cleaning up snapshot listeners in debug #13119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| firestore = FirebaseFirestore.instance; | ||
| collection = firestore | ||
| .collection('flutter-tests/web-snapshot-listeners/query-tests'); | ||
| document = collection.doc('doc1'); |
There was a problem hiding this comment.
Good it you can add a test with 2 ref on the same doc (since that was the original issue):
documentRef1 = collection.doc('doc1');
documentRef2 = collection.doc('doc1');
| @@ -101,7 +101,7 @@ class Firestore extends JsObjectWrapper<firestore_interop.FirestoreJsImpl> { | |||
| } | |||
|
|
|||
| // purely for debug mode and tracking listeners to clean up on "hot restart" | |||
| final Map<String, int> _snapshotInSyncListeners = {}; | |||
| static final Map<String, int> _snapshotInSyncListeners = {}; | |||
There was a problem hiding this comment.
Yeah! static is the solution!
Lyokone
approved these changes
Jul 30, 2024
|
Is there other places where this fix could be implemented? |
exaby73
approved these changes
Jul 30, 2024
|
@Lyokone - I think so, I'll have to double check as the issue was the map was being recreated for each query. I'll create PRs for others if needed 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
fixes #13019
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?