Improve GetDatabase Caching for Firestore Function Deployments #8681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
approved these changes
May 30, 2025
There was a problem hiding this comment.
This is different from the pattern we use in getExistingBackend (passing the cache via Context) to avoid accidentally using a cache, but I can see arguments that the problem is less of a concern here because we're not modifying the database region between calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying multiple 2nd gen Firestore functions, we send many concurrent GetDatabase API requests. The existing caching mechanism was not effective for these simultaneous calls, leading to redundant requests and (potentially) API quota issue.
This change introduces caching for the promise of the GetDatabase API call itself, in addition to the result. This should improves cache hits for concurrent requests, resulting in more reliable function deployments.