Improve log messages on skipped App Hosting source deploys #8674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annajowang
approved these changes
May 29, 2025
src/deploy/apphosting/prepare.ts
Outdated
Comment on lines
156
to
159
| logLabeledWarning( | ||
| "apphosting", | ||
| `Skipping deployment of backend(s) ${skippedBackends.map((cfg) => cfg.backendId).join(", ")}.`, | ||
| ); |
There was a problem hiding this comment.
do we want to hide this log under some if (skippedBackends.length > 0): ?
There was a problem hiding this comment.
Yes - thanks for catching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes misleading log messages during firebase deploy by hiding logs for skipped App Hosting backends and clearly listing which ones were skipped.
To improve user feedback, spinners will now be displayed during service account and web app creation to indicate that the operations are in progress.