XRPL - Orders filled but never completed then later gets successfully cancelled #7674
Description
Describe the bug
While testing and monitoring XRPL with v2 strategy {generic.pmm aand generic.pmm_adjusted} observed that there are instances of orders that are filled yet a cancellation event occur. Instead of the order getting a BuyOrderCompleted or SellOrderCompleted it completes the cancellation. See sample orders below:
--- Order ID: hbot-1750307217802-564872-BXPUC70f4b9eaa ---
[1782] 2025-06-19 04:27:31,989 - 2025-06-19 04:27:31,989 - 17 - hummingbot.connector.exchange.xrpl.xrpl_exchange.XrplExchange - INFO - Submitted order hbot-1750307217802-564872-BXPUC70f4b9eaa (96189194-96905551): type=OrderType.LIMIT_MAKER, pair=XRP-USDC, amount=2.310723, price=2.163691810000000, prelim_result=tesSUCCESS, tx_hash=4F18BC94EEC899FA8643D645E6AA74D41FCAFC2F7CF31CB51FECEF2F8E46A944
[1784] 2025-06-19 04:27:45,130 - 2025-06-19 04:27:45,130 - 17 - hummingbot.connector.client_order_tracker - INFO - Created LIMIT_MAKER BUY order hbot-1750307217802-564872-BXPUC70f4b9eaa for 2.310723 XRP-USDC at 2.163691810000000.
[1785] 2025-06-19 04:27:45,198 - 2025-06-19 04:27:45,198 - 17 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1750307265.0, "type": "OrderType.LIMIT_MAKER", "trading_pair": "XRP-USDC", "amount": "2.310723", "price": "2.163691810000000", "order_id": "hbot-1750307217802-564872-BXPUC70f4b9eaa", "creation_timestamp": 1750307217.0, "exchange_order_id": "96189194-96905551", "leverage": 1, "position": "NIL", "event_name": "BuyOrderCreatedEvent", "event_source": "xrpl"}
[1819] 2025-06-19 04:33:15,449 - 2025-06-19 04:33:15,449 - 17 - hummingbot.connector.client_order_tracker - INFO - The BUY order hbot-1750307217802-564872-BXPUC70f4b9eaa amounting to 2.310723/2.310723 XRP has been filled at 2.16369181 USDC.
[1820] 2025-06-19 04:33:15,518 - 2025-06-19 04:33:15,518 - 17 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1750307595.0, "order_id": "hbot-1750307217802-564872-BXPUC70f4b9eaa", "trading_pair": "XRP-USDC", "trade_type": "TradeType.BUY", "order_type": "OrderType.LIMIT_MAKER", "price": "2.16369181", "amount": "2.310723", "trade_fee": {"percent": "0.0", "percent_token": "USDC", "flat_fees": []}, "exchange_trade_id": "64020A6878CE3E6132878000076A566702054EBA6D8BB14B323F03EEA90C74A6", "exchange_order_id": "96189194-96905551", "leverage": 1, "position": "NIL", "event_name": "OrderFilledEvent", "event_source": "xrpl"}
[1847] 2025-06-19 04:38:21,109 - 2025-06-19 04:38:21,109 - 17 - hummingbot.strategy.script_strategy_base - INFO - (XRP-USDC) Canceling the limit order hbot-1750307217802-564872-BXPUC70f4b9eaa. [clock=2025-06-19 04:38:21+00:00]
[1853] 2025-06-19 04:38:28,391 - 2025-06-19 04:38:28,391 - 17 - hummingbot.connector.exchange.xrpl.xrpl_exchange.XrplExchange - INFO - Submitted cancel for order hbot-1750307217802-564872-BXPUC70f4b9eaa (96189194-96905551): prelim_result=tesSUCCESS, tx_hash=7F9DDAAFF595823BF25B5BDB4679FBE41A92BF328EE62E6915643250081D6879
[1855] 2025-06-19 04:38:37,478 - 2025-06-19 04:38:37,478 - 17 - hummingbot.connector.exchange.xrpl.xrpl_exchange.XrplExchange - INFO - Order hbot-1750307217802-564872-BXPUC70f4b9eaa reached final state: CANCELED
[1856] 2025-06-19 04:38:37,496 - 2025-06-19 04:38:37,496 - 17 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1750307917.0, "order_id": "hbot-1750307217802-564872-BXPUC70f4b9eaa", "exchange_order_id": "96189194-96905551", "event_name": "OrderCancelledEvent", "event_source": "xrpl"}
[1857] 2025-06-19 04:38:37,496 - 2025-06-19 04:38:37,496 - 17 - hummingbot.connector.client_order_tracker - INFO - Successfully canceled order hbot-1750307217802-564872-BXPUC70f4b9eaa.
--- Order ID: hbot-1750312043598-b0eeed-BXPUC1405c25cd ---
[2361] 2025-06-19 05:48:27,179 - 2025-06-19 05:48:27,179 - 17 - hummingbot.connector.exchange.xrpl.xrpl_exchange.XrplExchange - INFO - Submitted order hbot-1750312043598-b0eeed-BXPUC1405c25cd (96189280-96906800): type=OrderType.LIMIT_MAKER, pair=XRP-USDC, amount=2.304404, price=2.169400000000000, prelim_result=tesSUCCESS, tx_hash=34AEC897BE2DC3C5E6117CFA4539173F52374D95CD69BC1BE8953BE544EB53DB
[2362] 2025-06-19 05:48:37,922 - 2025-06-19 05:48:37,922 - 17 - hummingbot.connector.client_order_tracker - INFO - Created LIMIT_MAKER BUY order hbot-1750312043598-b0eeed-BXPUC1405c25cd for 2.304404 XRP-USDC at 2.169400000000000.
[2363] 2025-06-19 05:48:37,940 - 2025-06-19 05:48:37,940 - 17 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1750312117.0, "type": "OrderType.LIMIT_MAKER", "trading_pair": "XRP-USDC", "amount": "2.304404", "price": "2.169400000000000", "order_id": "hbot-1750312043598-b0eeed-BXPUC1405c25cd", "creation_timestamp": 1750312043.0, "exchange_order_id": "96189280-96906800", "leverage": 1, "position": "NIL", "event_name": "BuyOrderCreatedEvent", "event_source": "xrpl"}
[2396] 2025-06-19 05:54:28,836 - 2025-06-19 05:54:28,836 - 17 - hummingbot.connector.client_order_tracker - INFO - The BUY order hbot-1750312043598-b0eeed-BXPUC1405c25cd amounting to 2.304404/2.304404 XRP has been filled at 2.1694 USDC.
[2397] 2025-06-19 05:54:28,856 - 2025-06-19 05:54:28,856 - 17 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1750312468.0, "order_id": "hbot-1750312043598-b0eeed-BXPUC1405c25cd", "trading_pair": "XRP-USDC", "trade_type": "TradeType.BUY", "order_type": "OrderType.LIMIT_MAKER", "price": "2.1694", "amount": "2.304404", "trade_fee": {"percent": "0.0", "percent_token": "USDC", "flat_fees": []}, "exchange_trade_id": "4F79779A999D7315875AEE38ABB82EA36821368C771B2600B01A44635D17692F", "exchange_order_id": "96189280-96906800", "leverage": 1, "position": "NIL", "event_name": "OrderFilledEvent", "event_source": "xrpl"}
[2415] 2025-06-19 05:56:25,695 - 2025-06-19 05:56:25,695 - 17 - hummingbot.strategy.script_strategy_base - INFO - (XRP-USDC) Canceling the limit order hbot-1750312043598-b0eeed-BXPUC1405c25cd. [clock=2025-06-19 05:56:25+00:00]
[2417] 2025-06-19 05:56:45,435 - 2025-06-19 05:56:45,435 - 17 - hummingbot.connector.exchange.xrpl.xrpl_exchange.XrplExchange - INFO - Submitted cancel for order hbot-1750312043598-b0eeed-BXPUC1405c25cd (96189280-96906800): prelim_result=tesSUCCESS, tx_hash=54B44726D56852E15901ADDE7F59A84F83CEE7E58BF44738B354E99517827305
[2418] 2025-06-19 05:56:51,473 - 2025-06-19 05:56:51,473 - 17 - hummingbot.connector.exchange.xrpl.xrpl_exchange.XrplExchange - INFO - Order hbot-1750312043598-b0eeed-BXPUC1405c25cd reached final state: CANCELED
[2419] 2025-06-19 05:56:51,492 - 2025-06-19 05:56:51,492 - 17 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1750312611.0, "order_id": "hbot-1750312043598-b0eeed-BXPUC1405c25cd", "exchange_order_id": "96189280-96906800", "event_name": "OrderCancelledEvent", "event_source": "xrpl"}
[2420] 2025-06-19 05:56:51,492 - 2025-06-19 05:56:51,492 - 17 - hummingbot.connector.client_order_tracker - INFO - Successfully canceled order hbot-1750312043598-b0eeed-BXPUC1405c25cd.
--- Order ID: hbot-1750355811154-b50d2d-SXPUCcd747f480 ---
[7015] 2025-06-19 17:56:57,511 - 2025-06-19 17:56:57,511 - 17 - hummingbot.connector.exchange.xrpl.xrpl_exchange.XrplExchange - INFO - Submitted order hbot-1750355811154-b50d2d-SXPUCcd747f480 (96189701-96918008): type=OrderType.LIMIT_MAKER, pair=XRP-USDC, amount=2.302351, price=2.172139999999999, prelim_result=tesSUCCESS, tx_hash=9D66D5CFC846634A43B9A8BFE2286877EDFBBDDDE62CADC2AABC57C393C0F279
[7019] 2025-06-19 17:57:03,308 - 2025-06-19 17:57:03,308 - 17 - hummingbot.connector.client_order_tracker - INFO - Created LIMIT_MAKER SELL order hbot-1750355811154-b50d2d-SXPUCcd747f480 for 2.302351 XRP-USDC at 2.172139999999999.
[7020] 2025-06-19 17:57:03,321 - 2025-06-19 17:57:03,321 - 17 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1750355823.0, "type": "OrderType.LIMIT_MAKER", "trading_pair": "XRP-USDC", "amount": "2.302351", "price": "2.172139999999999", "order_id": "hbot-1750355811154-b50d2d-SXPUCcd747f480", "creation_timestamp": 1750355811.0, "exchange_order_id": "96189701-96918008", "leverage": 1, "position": "NIL", "event_name": "SellOrderCreatedEvent", "event_source": "xrpl"}
[7062] 2025-06-19 18:06:32,315 - 2025-06-19 18:06:32,315 - 17 - hummingbot.strategy.script_strategy_base - INFO - (XRP-USDC) Canceling the limit order hbot-1750355811154-b50d2d-SXPUCcd747f480. [clock=2025-06-19 18:06:32+00:00]
[7067] 2025-06-19 18:07:03,192 - 2025-06-19 18:07:03,192 - 17 - hummingbot.connector.exchange.xrpl.xrpl_exchange.XrplExchange - INFO - Submitted cancel for order hbot-1750355811154-b50d2d-SXPUCcd747f480 (96189701-96918008): prelim_result=tesSUCCESS, tx_hash=B98D0F16F9C2BF78DE51F4ADC0578C2C6C054C97726B089BDEB785FA61863633
[7076] 2025-06-19 18:07:08,963 - 2025-06-19 18:07:08,963 - 17 - hummingbot.connector.exchange.xrpl.xrpl_exchange.XrplExchange - INFO - Order hbot-1750355811154-b50d2d-SXPUCcd747f480 reached final state: CANCELED
[7077] 2025-06-19 18:07:08,975 - 2025-06-19 18:07:08,975 - 17 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1750356428.0, "order_id": "hbot-1750355811154-b50d2d-SXPUCcd747f480", "exchange_order_id": "96189701-96918008", "event_name": "OrderCancelledEvent", "event_source": "xrpl"}
[7078] 2025-06-19 18:07:08,975 - 2025-06-19 18:07:08,975 - 17 - hummingbot.connector.client_order_tracker - INFO - Successfully canceled order hbot-1750355811154-b50d2d-SXPUCcd747f480.
[7081] 2025-06-19 18:07:22,197 - 2025-06-19 18:07:22,197 - 17 - hummingbot.connector.client_order_tracker - INFO - The SELL order hbot-1750355811154-b50d2d-SXPUCcd747f480 amounting to 2.302351/2.302351 XRP has been filled at 2.172139999999998696984082792 USDC.
[7082] 2025-06-19 18:07:22,261 - 2025-06-19 18:07:22,261 - 17 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1750356442.0, "order_id": "hbot-1750355811154-b50d2d-SXPUCcd747f480", "trading_pair": "XRP-USDC", "trade_type": "TradeType.SELL", "order_type": "OrderType.LIMIT_MAKER", "price": "2.172139999999998696984082792", "amount": "2.302351", "trade_fee": {"percent": "0", "percent_token": "XRP", "flat_fees": []}, "exchange_trade_id": "25F42DA220EBA8020DF77F939CA0C81AAFC429B3AA88243AA0CF7DE7D3E6DB93", "exchange_order_id": "96189701-96918008", "leverage": 1, "position": "NIL", "event_name": "OrderFilledEvent", "event_source": "xrpl"}
- Observed that there’s 2-3minutes gap between order filled and submitted as cancellation
- Assuming that the offer was already filled on XRPL and nothing left then the cancellation txn occurred to close/cancel offer for cleanup?
- Another instance is when the order was in the process of cancellation and completed yet the order was filled
- Its possible that the order was in queue for cancellation but offer matched another and filled
- Therefore it still proceed to offerCancel for “cleanup” then later added that the order was filled on exchange but not completed on hummingbot
Steps to reproduce
- Setup v2 controller with XRPL and run long term bots
- Review all orders that have been filled
Release version
2.6.1 and dev2.7.0
Type of installation
Source