From 2df45c874db8bd12e437f31198ab9519511df0ae Mon Sep 17 00:00:00 2001 From: Anon Ray Date: Wed, 6 May 2020 16:15:10 +0530 Subject: [PATCH 1/2] docs: fix wrong info of excluding scheme in CORS config --- CHANGELOG.md | 1 + .../manual/deployment/graphql-engine-flags/reference.rst | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b30b1c3342f7..f9f1c218ce1af 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -63,6 +63,7 @@ using this flag is insecure since verification is not carried out. - cli: remove irrelevant flags from init command (close #4508) (#4549) - docs: update migrations docs with config v2 (#4586) - docs: update actions docs (#4586) +- docs: fix wrong info about excluding scheme in CORS config ## `v1.2.0-beta.5` diff --git a/docs/graphql/manual/deployment/graphql-engine-flags/reference.rst b/docs/graphql/manual/deployment/graphql-engine-flags/reference.rst index 986b2b2d80267..4d0319ab3324e 100644 --- a/docs/graphql/manual/deployment/graphql-engine-flags/reference.rst +++ b/docs/graphql/manual/deployment/graphql-engine-flags/reference.rst @@ -110,8 +110,8 @@ For the ``serve`` sub-command these are the available flags and ENV variables: * - ``--cors-domain `` - ``HASURA_GRAPHQL_CORS_DOMAIN`` - - CSV of list of domains, excluding scheme (http/https) and including port, - to allow for CORS. Wildcard domains are allowed. + - CSV of list of domains, incuding scheme (http/https) and port, to allow for CORS. Wildcard + domains are allowed. (See :ref:`configure-cors`) * - ``--disable-cors`` - ``HASURA_GRAPHQL_DISABLE_CORS`` From 8524d90e414fa0b6b7fde97e2a8557fcd1ca63d8 Mon Sep 17 00:00:00 2001 From: Anon Ray Date: Fri, 8 May 2020 14:05:22 +0530 Subject: [PATCH 2/2] move changelog item to Next Release --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f9f1c218ce1af..84cf7d2c94eb6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,6 +38,7 @@ Read more about the session argument for computed fields in the [docs](https://h - console: add read replica support section to pro popup (#4118) - cli: list all avialable commands in root command help (fix #4623) +- docs: fix wrong info about excluding scheme in CORS config ## `v1.2.0` @@ -63,7 +64,6 @@ using this flag is insecure since verification is not carried out. - cli: remove irrelevant flags from init command (close #4508) (#4549) - docs: update migrations docs with config v2 (#4586) - docs: update actions docs (#4586) -- docs: fix wrong info about excluding scheme in CORS config ## `v1.2.0-beta.5`