From e129bfad88a7c0b3647478a7fc626ac2f9b8d1b1 Mon Sep 17 00:00:00 2001 From: rikinsk Date: Tue, 8 Oct 2019 16:32:30 +0530 Subject: [PATCH 1/2] fix readme --- console/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/console/README.md b/console/README.md index cb4783d9eb646..66c4f2a78550b 100644 --- a/console/README.md +++ b/console/README.md @@ -42,7 +42,7 @@ npm install ### Run console development server -Hasura console can be developed in two modes, `server` or `cli` mode. If you are looking to add/tweak functionality related to migrations, check out [Development with Hasura CLI](#development-with-hasura-cli-cli-mode), otherwise check out [Development with Hasura GraphQL engine](#development-with-hasura-graphql-engine-server-mode). +Hasura console can be developed in two modes, `server` or `cli` mode. If you are looking to add/tweak functionality related to migrations, check out [Develop with Hasura CLI](#develop-with-hasura-cli-cli-mode), otherwise check out [Develop with Hasura GraphQL engine](#develop-with-hasura-graphql-engine-server-mode). Both modes require a running instance of GraphQL Engine. The easiest way to get Hasura GraphQL engine instance is by Heroku. You can get it by following the steps given in [this](https://docs.hasura.io/1.0/graphql/manual/getting-started/heroku-simple.html) link. Other methods to install Hasura GraphQL engine are documented [here](https://docs.hasura.io/1.0/graphql/manual/getting-started/index.html). @@ -62,7 +62,7 @@ Environment variables accepted in `server` mode: - `ASSETS_VERSION`: Version of console assets being served - `ENABLE_TELEMETRY`: Whether to enable telemetry (`true`/`false`) - `URL_PREFIX`: Path at which the console is running -- `DATA_API_URL`: The Hasura GraphQL engine url. (If you are running it on Heroku, it will look like .herokuapp.com, if you are running locally, it will look like http://localhost:) +- `DATA_API_URL`: The Hasura GraphQL engine url. (If you are running it on Heroku, it will look like .herokuapp.com, if you are running locally, it will look like http://localhost:) - `SERVER_VERSION`: Hasura GraphQL Engine server version - `CONSOLE_MODE`: In server mode, it should be `server` - `IS_ADMIN_SECRET_SET`: Is GraphQl engine configured with an admin secret (`true`/`false`) @@ -106,7 +106,7 @@ Environment variables accepted in `cli` mode: - `ASSETS_VERSION`: Version of console assets being served - `ENABLE_TELEMETRY`: Whether to enable telemetry (`true`/`false`) - `URL_PREFIX`: Path at which the console is running -- `DATA_API_URL`: The Hasura GraphQL engine url. (If you are running it on Heroku, it will look like .herokuapp.com, if you are running locally, it will look like http://localhost:) +- `DATA_API_URL`: The Hasura GraphQL engine url. (If you are running it on Heroku, it will look like .herokuapp.com, if you are running locally, it will look like http://localhost:) - `SERVER_VERSION`: Hasura GraphQL Engine server version - `CONSOLE_MODE`: In cli mode, it should be `cli` - `ADMIN_SECRET`: the admin secret passed via the CLI From dde820fac311a72458b0f88e5d30d23698c12b68 Mon Sep 17 00:00:00 2001 From: rikinsk Date: Wed, 9 Oct 2019 19:04:04 +0530 Subject: [PATCH 2/2] fix console dataApiUrl --- console/src/Globals.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/console/src/Globals.js b/console/src/Globals.js index e2d6efea92c55..ee4d8cd11a867 100644 --- a/console/src/Globals.js +++ b/console/src/Globals.js @@ -20,7 +20,7 @@ if ( /* initialize globals */ -const isProduction = window.__env.nodeEnv === 'production'; +const isProduction = window.__env.nodeEnv !== 'development'; const globals = { apiHost: window.__env.apiHost,