From 3d135f8d3fa4914fbceb7565332542f79d5bf303 Mon Sep 17 00:00:00 2001
From: strongSoda <strongsoda2@gmail.com>
Date: Mon, 27 May 2019 16:26:23 +0530
Subject: [PATCH 1/4] #1468 solved

---
 .../components/Services/Data/TableModify/ColumnEditor.js  | 8 ++++++--
 .../Services/Data/TableModify/ColumnEditorList.js         | 5 +++++
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/console/src/components/Services/Data/TableModify/ColumnEditor.js b/console/src/components/Services/Data/TableModify/ColumnEditor.js
index 2760326703514..3cd4ae48b647b 100644
--- a/console/src/components/Services/Data/TableModify/ColumnEditor.js
+++ b/console/src/components/Services/Data/TableModify/ColumnEditor.js
@@ -26,9 +26,9 @@ const ColumnEditor = ({
   selectedProperties,
   editColumn,
   alterTypeOptions,
+  pkLength,
 }) => {
   const colName = columnProperties.name;
-
   if (!selectedProperties[colName]) {
     return null;
   }
@@ -136,7 +136,11 @@ const ColumnEditor = ({
           <div className="col-xs-6">
             <select
               className="input-sm form-control"
-              value={selectedProperties[colName].isUnique}
+              value={
+                columnProperties.pkConstraint && pkLength === 1
+                  ? !selectedProperties[colName].isUnique
+                  : selectedProperties[colName].isUnique
+              }
               onChange={toggleColumnUnique}
               disabled={columnProperties.pkConstraint}
               data-test="edit-col-unique"
diff --git a/console/src/components/Services/Data/TableModify/ColumnEditorList.js b/console/src/components/Services/Data/TableModify/ColumnEditorList.js
index b032a06c831a0..3b4d1ecb40127 100644
--- a/console/src/components/Services/Data/TableModify/ColumnEditorList.js
+++ b/console/src/components/Services/Data/TableModify/ColumnEditorList.js
@@ -21,11 +21,15 @@ const ColumnEditorList = ({
   dispatch,
   validTypeCasts,
   dataTypeIndexMap,
+  pkLength,
 }) => {
   const tableName = tableSchema.table_name;
 
   const columnPKConstraints = {};
   if (tableSchema.primary_key) {
+    // calculating number of primary keys for issue #1468
+    // showing unique: false for primary key column is confusing
+    pkLength = tableSchema.primary_key.columns.length;
     tableSchema.primary_key.columns.forEach(col => {
       columnPKConstraints[col] = tableSchema.primary_key.constraint_name;
     });
@@ -149,6 +153,7 @@ const ColumnEditorList = ({
           columnProperties={columnProperties}
           selectedProperties={columnEdit}
           editColumn={editColumn}
+          pkLength={pkLength}
         />
       );
     };

From 9d049fbb5cd5e997c65a87933b68bb41115f8295 Mon Sep 17 00:00:00 2001
From: strongSoda <strongsoda2@gmail.com>
Date: Mon, 27 May 2019 17:06:51 +0530
Subject: [PATCH 2/4] made required changes

---
 .../src/components/Services/Data/TableModify/ColumnEditor.js | 5 ++---
 .../components/Services/Data/TableModify/ColumnEditorList.js | 2 --
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/console/src/components/Services/Data/TableModify/ColumnEditor.js b/console/src/components/Services/Data/TableModify/ColumnEditor.js
index 3cd4ae48b647b..f3fe847b35b67 100644
--- a/console/src/components/Services/Data/TableModify/ColumnEditor.js
+++ b/console/src/components/Services/Data/TableModify/ColumnEditor.js
@@ -137,9 +137,8 @@ const ColumnEditor = ({
             <select
               className="input-sm form-control"
               value={
-                columnProperties.pkConstraint && pkLength === 1
-                  ? !selectedProperties[colName].isUnique
-                  : selectedProperties[colName].isUnique
+                selectedProperties[colName].isUnique ||
+                (columnProperties.pkConstraint && pkLength === 1)
               }
               onChange={toggleColumnUnique}
               disabled={columnProperties.pkConstraint}
diff --git a/console/src/components/Services/Data/TableModify/ColumnEditorList.js b/console/src/components/Services/Data/TableModify/ColumnEditorList.js
index 3b4d1ecb40127..efe583d017b68 100644
--- a/console/src/components/Services/Data/TableModify/ColumnEditorList.js
+++ b/console/src/components/Services/Data/TableModify/ColumnEditorList.js
@@ -27,8 +27,6 @@ const ColumnEditorList = ({
 
   const columnPKConstraints = {};
   if (tableSchema.primary_key) {
-    // calculating number of primary keys for issue #1468
-    // showing unique: false for primary key column is confusing
     pkLength = tableSchema.primary_key.columns.length;
     tableSchema.primary_key.columns.forEach(col => {
       columnPKConstraints[col] = tableSchema.primary_key.constraint_name;

From a4f341e98a07a538b1cb262607771f3f3a6ae23a Mon Sep 17 00:00:00 2001
From: rikinsk <rikin.kachhia@gmail.com>
Date: Mon, 27 May 2019 19:21:25 +0530
Subject: [PATCH 3/4] f

---
 .../Services/Data/TableModify/ColumnEditor.js          |  7 ++-----
 .../Services/Data/TableModify/ColumnEditorList.js      | 10 +++++++---
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/console/src/components/Services/Data/TableModify/ColumnEditor.js b/console/src/components/Services/Data/TableModify/ColumnEditor.js
index f3fe847b35b67..2760326703514 100644
--- a/console/src/components/Services/Data/TableModify/ColumnEditor.js
+++ b/console/src/components/Services/Data/TableModify/ColumnEditor.js
@@ -26,9 +26,9 @@ const ColumnEditor = ({
   selectedProperties,
   editColumn,
   alterTypeOptions,
-  pkLength,
 }) => {
   const colName = columnProperties.name;
+
   if (!selectedProperties[colName]) {
     return null;
   }
@@ -136,10 +136,7 @@ const ColumnEditor = ({
           <div className="col-xs-6">
             <select
               className="input-sm form-control"
-              value={
-                selectedProperties[colName].isUnique ||
-                (columnProperties.pkConstraint && pkLength === 1)
-              }
+              value={selectedProperties[colName].isUnique}
               onChange={toggleColumnUnique}
               disabled={columnProperties.pkConstraint}
               data-test="edit-col-unique"
diff --git a/console/src/components/Services/Data/TableModify/ColumnEditorList.js b/console/src/components/Services/Data/TableModify/ColumnEditorList.js
index efe583d017b68..e450473a4fc4c 100644
--- a/console/src/components/Services/Data/TableModify/ColumnEditorList.js
+++ b/console/src/components/Services/Data/TableModify/ColumnEditorList.js
@@ -21,13 +21,14 @@ const ColumnEditorList = ({
   dispatch,
   validTypeCasts,
   dataTypeIndexMap,
-  pkLength,
 }) => {
   const tableName = tableSchema.table_name;
 
+  let pkLength = 0;
   const columnPKConstraints = {};
   if (tableSchema.primary_key) {
     pkLength = tableSchema.primary_key.columns.length;
+
     tableSchema.primary_key.columns.forEach(col => {
       columnPKConstraints[col] = tableSchema.primary_key.constraint_name;
     });
@@ -57,7 +58,11 @@ const ColumnEditorList = ({
       type: col.udt_name,
       isNullable: col.is_nullable === 'YES',
       pkConstraint: columnPKConstraints[colName],
-      isUnique: columnUniqueConstraints[colName] ? true : false,
+      isUnique:
+        (columnPKConstraints[colName] && pkLength === 1) ||
+        columnUniqueConstraints[colName]
+          ? true
+          : false,
       // uniqueConstraint: columnUniqueConstraints[colName],
       default: col.column_default || '',
     };
@@ -151,7 +156,6 @@ const ColumnEditorList = ({
           columnProperties={columnProperties}
           selectedProperties={columnEdit}
           editColumn={editColumn}
-          pkLength={pkLength}
         />
       );
     };

From df9c40417dbe973e91172fb2ff79b529fe81d87b Mon Sep 17 00:00:00 2001
From: rikinsk <rikin.kachhia@gmail.com>
Date: Mon, 27 May 2019 19:45:58 +0530
Subject: [PATCH 4/4] fix breadCrumbs

---
 .../Data/TableBrowseRows/ViewHeader.js        | 47 +++++++++++-------
 .../Services/Data/TableCommon/TableHeader.js  | 48 +++++++++++--------
 console/src/components/Services/Data/utils.js |  2 +-
 .../EventTrigger/TableCommon/TableHeader.js   | 40 +++++++++++-----
 4 files changed, 86 insertions(+), 51 deletions(-)

diff --git a/console/src/components/Services/Data/TableBrowseRows/ViewHeader.js b/console/src/components/Services/Data/TableBrowseRows/ViewHeader.js
index 2a0e1413fb60a..1301dbf80ddb2 100644
--- a/console/src/components/Services/Data/TableBrowseRows/ViewHeader.js
+++ b/console/src/components/Services/Data/TableBrowseRows/ViewHeader.js
@@ -4,6 +4,7 @@ import Helmet from 'react-helmet';
 import globals from '../../../../Globals';
 import { changeTableOrViewName } from '../TableModify/ModifyActions';
 import EditableHeading from '../../../Common/EditableHeading/EditableHeading';
+import BreadCrumb from '../../../Common/Layout/BreadCrumb/BreadCrumb';
 import { tabNameMap } from '../utils';
 
 const ViewHeader = ({
@@ -38,28 +39,38 @@ const ViewHeader = ({
       )
     );
   };
+
+  const getBreadCrumbs = () => {
+    return [
+      {
+        title: 'Data',
+        url: '/data',
+      },
+      {
+        title: 'Schema',
+        url: '/data/schema/',
+      },
+      {
+        title: currentSchema,
+        url: '/data/schema/' + currentSchema,
+      },
+      {
+        title: tableName,
+        url:
+          '/data/schema/' + currentSchema + '/views/' + tableName + '/browse',
+      },
+      {
+        title: activeTab,
+        url: null,
+      },
+    ];
+  };
+
   return (
     <div>
       <Helmet title={capitalised + ' - ' + tableName + ' - Data | Hasura'} />
       <div className={styles.subHeader}>
-        <div className={styles.dataBreadCrumb}>
-          You are here: <Link to={'/data/schema/' + currentSchema}>Data</Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" />{' '}
-          <Link to={'/data/schema/' + currentSchema}>Schema</Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" />{' '}
-          <Link
-            to={
-              '/data/schema/' +
-              currentSchema +
-              '/views/' +
-              tableName +
-              '/browse'
-            }
-          >
-            {tableName}
-          </Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" /> {activeTab}
-        </div>
+        <BreadCrumb breadCrumbs={getBreadCrumbs()} />
         <EditableHeading
           currentValue={tableName}
           save={saveViewNameChange}
diff --git a/console/src/components/Services/Data/TableCommon/TableHeader.js b/console/src/components/Services/Data/TableCommon/TableHeader.js
index 38cc04dce3c64..4bec307e7d847 100644
--- a/console/src/components/Services/Data/TableCommon/TableHeader.js
+++ b/console/src/components/Services/Data/TableCommon/TableHeader.js
@@ -4,6 +4,7 @@ import { Link } from 'react-router';
 import Helmet from 'react-helmet';
 import { changeTableOrViewName } from '../TableModify/ModifyActions';
 import EditableHeading from '../../../Common/EditableHeading/EditableHeading';
+import BreadCrumb from '../../../Common/Layout/BreadCrumb/BreadCrumb';
 import { tabNameMap } from '../utils';
 
 const TableHeader = ({
@@ -45,30 +46,37 @@ const TableHeader = ({
     );
   };
 
+  const getBreadCrumbs = () => {
+    return [
+      {
+        title: 'Data',
+        url: '/data',
+      },
+      {
+        title: 'Schema',
+        url: '/data/schema/',
+      },
+      {
+        title: currentSchema,
+        url: '/data/schema/' + currentSchema,
+      },
+      {
+        title: tableName,
+        url:
+          '/data/schema/' + currentSchema + '/tables/' + tableName + '/browse',
+      },
+      {
+        title: activeTab,
+        url: null,
+      },
+    ];
+  };
+
   return (
     <div>
       <Helmet title={capitalised + ' - ' + tableName + ' - Data | Hasura'} />
       <div className={styles.subHeader}>
-        <div className={styles.dataBreadCrumb}>
-          You are here: <Link to={'/data/schema/' + currentSchema}>Data</Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" />{' '}
-          <Link to={'/data/schema/' + currentSchema}>Schema</Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" />{' '}
-          <Link to={'/data/schema/' + currentSchema}>{currentSchema}</Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" />{' '}
-          <Link
-            to={
-              '/data/schema/' +
-              currentSchema +
-              '/tables/' +
-              tableName +
-              '/browse'
-            }
-          >
-            {tableName}
-          </Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" /> {activeTab}
-        </div>
+        <BreadCrumb breadCrumbs={getBreadCrumbs()} />
         <EditableHeading
           currentValue={tableName}
           save={saveTableNameChange}
diff --git a/console/src/components/Services/Data/utils.js b/console/src/components/Services/Data/utils.js
index 8bea554fe57e8..ede5b7662e119 100644
--- a/console/src/components/Services/Data/utils.js
+++ b/console/src/components/Services/Data/utils.js
@@ -42,7 +42,7 @@ export const getPlaceholder = type => {
 };
 
 export const tabNameMap = {
-  view: 'Browse Rows',
+  browse: 'Browse Rows',
   insert: 'Insert Row',
   modify: 'Modify',
   relationships: 'Relationships',
diff --git a/console/src/components/Services/EventTrigger/TableCommon/TableHeader.js b/console/src/components/Services/EventTrigger/TableCommon/TableHeader.js
index e7f685f92b86a..7b9ce9df3a36f 100644
--- a/console/src/components/Services/EventTrigger/TableCommon/TableHeader.js
+++ b/console/src/components/Services/EventTrigger/TableCommon/TableHeader.js
@@ -1,6 +1,7 @@
 import React from 'react';
 import { Link } from 'react-router';
 import Helmet from 'react-helmet';
+import BreadCrumb from '../../../Common/Layout/BreadCrumb/BreadCrumb';
 
 const TableHeader = ({ triggerName, tabName, count }) => {
   const styles = require('./EventTable.scss');
@@ -20,24 +21,39 @@ const TableHeader = ({ triggerName, tabName, count }) => {
   } else if (tabName === 'logs') {
     activeTab = 'Logs';
   }
+
+  const getBreadCrumbs = () => {
+    return [
+      {
+        title: 'Events',
+        url: '/events',
+      },
+      {
+        title: 'Manage',
+        url: '/events/manage',
+      },
+      {
+        title: 'Triggers',
+        url: '/events/manage/triggers/',
+      },
+      {
+        title: triggerName,
+        url: '/events/manage/triggers/' + triggerName + '/processed',
+      },
+      {
+        title: activeTab,
+        url: null,
+      },
+    ];
+  };
+
   return (
     <div>
       <Helmet
         title={capitalised + ' - ' + triggerName + ' - Event Triggers | Hasura'}
       />
       <div className={styles.subHeader}>
-        <div className={styles.dataBreadCrumb}>
-          You are here: <Link to={'/events'}>Events</Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" />{' '}
-          <Link to={'/events/manage'}>Manage</Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" />{' '}
-          <Link to={'/events/manage/triggers'}>Triggers</Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" />{' '}
-          <Link to={'/events/manage/triggers/' + triggerName + '/processed'}>
-            {triggerName}
-          </Link>{' '}
-          <i className="fa fa-angle-right" aria-hidden="true" /> {activeTab}
-        </div>
+        <BreadCrumb breadCrumbs={getBreadCrumbs()} />
         <h2 className={styles.heading_text}>{triggerName}</h2>
         <div className={styles.nav}>
           <ul className="nav nav-pills">