这是indexloc提供的服务,不要输入任何密码
Skip to content

otel status value for the graphql engine metadata cannot be sourced from env vars similar to other otel properties #10177

@krisiye

Description

@krisiye

Version Information

Server Version:
CLI Version (for CLI related issue):
v2.37.0

Environment

All environments. Self Hosted and Cloud.

What is the current behaviour?

Hasura Metadata at the moment does not allow one to turn off open telemetry on a given stage if you chose to. The typical use-case is to allow some flexibility to turn on/off local or non prod stages.

What is the expected behaviour?

  1. Expected behavior is to allow otel status to be read from an environment var similar to any other OTEL config.

How to reproduce the issue?

Try making otel status a variable that we expect to read from env.

Screenshots or Screencast

NA

Please provide any traces or logs that could help here.

Appears to be not compatible with {{otel.status}} (assuming an env var otel.status injected with this name):
error: yaml: invalid map key: map[string]interface {}{"OTEL_STATUS":interface {}(nil)}

Also tried to put vars behind quotes and got the following:

{
  "error": "OpenTelemetry status must be either \"enabled\" or \"disabled\"",
  "path": "$.args.metadata.opentelemetry.status",
  "code": "parse-failed"
} ```


### Any possible solutions/workarounds you're aware of?

NA

### Keywords

open telemetry

Metadata

Metadata

Assignees

No one assigned

    Labels

    k/enhancementNew feature or improve an existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions