From 32274ba6304374b42a4e0137e74fbae71fff5e46 Mon Sep 17 00:00:00 2001 From: munahaf Date: Fri, 6 Oct 2023 18:16:10 +0000 Subject: [PATCH 1/3] Comment: Fixed an inappropriate test expression to remove a logical short circuit. --- openage/convert/processor/conversion/aoc/processor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openage/convert/processor/conversion/aoc/processor.py b/openage/convert/processor/conversion/aoc/processor.py index 01863e54c0..4a645d0c9f 100644 --- a/openage/convert/processor/conversion/aoc/processor.py +++ b/openage/convert/processor/conversion/aoc/processor.py @@ -663,7 +663,7 @@ def create_building_lines(full_data_set: GenieObjectContainer) -> None: upgrade_effects = effect_bundle.get_effects(effect_type=3) - if len(upgrade_effects) < 0: + if not upgrade_effects: continue # Search upgrade effects for the line_id From eacac66c39953777062a5128a1dfc651119868c6 Mon Sep 17 00:00:00 2001 From: Munawar Date: Fri, 6 Oct 2023 14:24:08 -0700 Subject: [PATCH 2/3] Changed test expression per reviewer's suggestion. --- openage/convert/processor/conversion/aoc/processor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openage/convert/processor/conversion/aoc/processor.py b/openage/convert/processor/conversion/aoc/processor.py index 4a645d0c9f..6f03cc3421 100644 --- a/openage/convert/processor/conversion/aoc/processor.py +++ b/openage/convert/processor/conversion/aoc/processor.py @@ -663,7 +663,7 @@ def create_building_lines(full_data_set: GenieObjectContainer) -> None: upgrade_effects = effect_bundle.get_effects(effect_type=3) - if not upgrade_effects: + if len(upgrade_effects) == 0: continue # Search upgrade effects for the line_id From 9422cbee38eaf271c449713e59531d3c22ad5ca2 Mon Sep 17 00:00:00 2001 From: Munawar Date: Fri, 6 Oct 2023 14:21:46 -0700 Subject: [PATCH 3/3] Added name for the following PR https://github.com/SFTtech/openage/pull/1559#issuecomment-1751376682 --- copying.md | 1 + 1 file changed, 1 insertion(+) diff --git a/copying.md b/copying.md index 7add8d2036..310076a011 100644 --- a/copying.md +++ b/copying.md @@ -147,6 +147,7 @@ _the openage authors_ are: | Martin | Starman | mstarman à seznam dawt cz | | Zoltán Ács | zoli111 | acszoltan111 à gmail dawt com | | Trevor Slocum | tslocum | trevor à rocket9labs dawt com | +| Munawar Hafiz | munahaf | munawar dawt hafiz à gmail dawt com | If you're a first-time committer, add yourself to the above list. This is not just for legal reasons, but also to keep an overview of all those nicknames.