-
Notifications
You must be signed in to change notification settings - Fork 261
Closed
Labels
Milestone
Description
In _ppdCacheGetInputSlot(), there's a check that tries to look up the value for "photo" if media-source wasn't supplied in the request. This seems to work fine for a lot of printers, but breaks in this scenario:
- Japanese printer has an L-sized photo tray.
- User loads Hagaki paper in the main tray and tries to print without specifying a tray.
- cupsd sees that Hagaki is smaller than 5x7" and automatically requests the photo tray.
- Printer fails the job because Hagaki can't be loaded from the L-sized photo tray.
Should this check change to look up "auto" instead? Based on our PPD database, removing it entirely would break a few models, but "auto" should work in nearly every case. With a small refactor, it could also keep the "photo" case as a fallback for PPDs that have a photo InputSlot option but not an auto option.